The data_function key was removed from the vimeo integration in the last update. This causes some problems with identifying the handler of the video URL and is an API change.

CommentFileSizeAuthor
#4 handler_key_never-2555113-4.patch690 bytesLeon Kessler
#2 2555113-bring-back-vimeo-data-function.patch1.16 KBSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and commented
Status: Active » Needs review
FileSize
2555113-bring-back-vimeo-data-function.patch1.16 KB

This patch brings it back and makes it share the same function as the thumbnail callback. It seems useful that the same keys are okay to store in data (namely ID), and it's a requirement that something goes in there to get the handler metadata.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Nice catch works for me locally.

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
Status: Reviewed & tested by the community » Needs review
FileSize
handler_key_never-2555113-4.patch690 bytes

Why not save the full set of data (rather than just the thumbnail)?

Also renaming this function is confusing, doesn't describe the intended behaviour.

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
Related issues: +#1996924: Empty private Vimeo thumbnails

Adding related issue (for when the data_function was removed)

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented

Also, can you clarify what you mean by handler key? Where should this key appear? How are you using it?

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc at Bluespark commented
Status: Needs review » Fixed

Pushed to 7.x-2.x-dev

Thank you!

  • plopesc committed db6ec91 on 7.x-2.x authored by leon.nk 
    Issue #2555113 by Sam152, leon.nk: 'handler' key never gets set when the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.