Problem/Motivation
i posted the error in the wrong forum of video_embed_field: https://www.drupal.org/project/video_embed_field/issues/3519459
I get a Drupal 11 on node save form :
Fatal error: Declaration of Drupal\video_embed_facebook\Plugin\video_embed_field\Provider\Facebook::renderEmbedCode($width, $height, $autoplay) must be compatible with Drupal\video_embed_field\ProviderPluginInterface::renderEmbedCode($width, $height, $autoplay, $title_format = null, $use_title_fallback = true) in /var/www/html/docroot/web/modules/contrib/video_embed_facebook/src/Plugin/video_embed_field/Provider/Facebook.php on line 18
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | video-embed-3x-compatibility-3519611-10.patch | 2.14 KB | mkrizaj |
Issue fork video_embed_facebook-3519611
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
mably commentedI suggest to create a new 3.x branch for the 3.0.x compatible release.
Comment #5
mably commentedComment #6
mably commentedIt would be interesting to be able to fetch the video title using the FB graph API.
Here is a piece of code ChatGPT generated that could be of some help to do that:
Comment #7
mably commentedAnd it looks like the thumbnail fetching code needs to be updated too:
AI generated code posted here, just in case:
Looks like a patch have been provided here: https://www.drupal.org/project/video_embed_facebook/issues/3002106
Comment #8
mably commentedWill see what I can do if some people are interested.
Comment #9
renrhaf+1, working !
Comment #10
mkrizaj commentedHi @renrhaf and @mably.
I've recreated the patch and merged the changes from both PR into one. Please take a look and let me know what you think.