CommentFileSizeAuthor
#12 3125595-12.patch399 bytesflocondetoile
#7 Content created Successfully.png367.74 KBmanojithape
#7 After patch.png28.71 KBmanojithape
#7 Patch applied successfully.png17.43 KBmanojithape
#7 Before patch.png53.07 KBmanojithape
#2 3125595-2.patch397 bytessuresh prabhu parkala

Issue fork video_embed_dailymotion-3125595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Suresh Prabhu Parkala created an issue. See original summary.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3125595-2.patch397 bytes

Please review!

alasserr’s picture

alasserr
Primary language French
Location Lyon
commented

It works on my Drupal 9.0.1 website. No errors so far.

ambuj_gupta’s picture

ambuj_gupta commented
Assigned: Unassigned » ambuj_gupta
ambuj_gupta’s picture

ambuj_gupta commented
Assigned: ambuj_gupta » Unassigned
manojithape’s picture

manojithape commented
Assigned: Unassigned » manojithape
manojithape’s picture

manojithape commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before patch.png53.07 KB
new Patch applied successfully.png17.43 KB
new After patch.png28.71 KB
new Content created Successfully.png367.74 KB

Verified and tested patch#2. Patch applied successfully and looks good to me. Please refer attached screenshot.

Testing Steps:
1. Verify that in Drupal 9, As a user i am able to Install "Video Embed Dailymotion" module and other required modules like Video Embed Field module without any error.
2. Add "Video Embed" field in content type
3. Verify that user is able to create video content without any error.

Testing Results:
1. In Drupal 9, As a user i am able to install "Video Embed Dailymotion" module and other required modules like "Video Embed Field" module without any error.
2. As a user i am able to create video content without any error.

manojithape’s picture

manojithape commented
Assigned: manojithape » Unassigned

jhiver made their first commit to this issue’s fork.

dunebl’s picture

dunebl
Primary language French
commented

Patch failed

patching file video_embed_dailymotion.info.yml
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file video_embed_dailymotion.info.yml.rej
b2f’s picture

b2f commented

It passes on dev branch

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
StatusFileSize
new 3125595-12.patch399 bytes

Waiting a new release compatible D9, added a patch compatible with 8.x-1.1.

flocondetoile opened merge request !1

  • flocondetoile authored 26ac335 on 8.x-1.x 
    Issue #3125595 by flocondetoile, Suresh Prabhu Parkala: Drupal 9...
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented

Committed. Thanks.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Reviewed & tested by the community » Fixed
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented

For info, D9 compatible release published.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.