It would be useful to allow more matching to enable editors to use short URLs or embed URLs in the field. e.g:

http://www.dailymotion.com/video/x1g5nn
http://dai.ly/x1g5nn
http://www.dailymotion.com/embed/video/x1g5nn

The user could have copied any of those three from DailyMotion but only the first one will be matched in the field.

CommentFileSizeAuthor
#8 2900403-8.patch759 bytesflocondetoile
#7 2900403-7.patch757 bytesflocondetoile
#6 2900403-6.patch752 bytesflocondetoile
#2 2900403-1.patch757 byteschrishks

Comments

chrishks created an issue. See original summary.

chrishks’s picture

chrishks commented
StatusFileSize
new 2900403-1.patch757 bytes
chrishks’s picture

chrishks commented
Status: Active » Needs review
sylvainm’s picture

sylvainm commented
Status: Needs review » Reviewed & tested by the community

It works good for me, thx :-)

anfor’s picture

anfor commented
Priority: Normal » Major

Thanks @chrishks, it works great.
You also fixed the 6 to 7 characters for video ID.
Moving the priority to major because the patch drastically simplify user's contribution.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Category: Feature request » Bug report
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2900403-6.patch752 bytes

Regex in #2 doesn't work for dailymotion url with an id greater than 7 characters
exemple: https://www.dailymotion.com/video/k4yq22IxAu6vqBrKyXc

Updated the regex to match too this URL types.

Moving to bug report because some Dailymotion URL can't be used.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
StatusFileSize
new 2900403-7.patch757 bytes

Sorry ignore #6.
Good patch attached.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
StatusFileSize
new 2900403-8.patch759 bytes

patch rerolled against -dev

  • flocondetoile authored 9e8172a on 8.x-1.x 
    Issue #2900403 by flocondetoile, chrishks: Allow short URLs and embed...
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Needs review » Fixed

#8 committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.