Problem/Motivation

The Events listing's exposed filters render through Varbase Components' components_exposed_form. Unlike the BEF-driven News and Programs listings, components_exposed_form has no reset_button_always_show option, so it inherits Drupal core's behaviour of hiding the Reset action (#access set to FALSE) until an exposed input is present. As a result the Reset action never appears on the unfiltered /events page, so the Events filter row does not match the News and Programs filter rows, which always show both Apply Filter and Reset.

Steps to reproduce

  1. Install the Educare site template.
  2. Visit /events while logged out.
  3. The exposed filter row shows Apply Filter but no Reset action, while /news and /programs show both.

Proposed resolution

Reveal the already-built, functional Reset action for the events view in hook_form_alter(), alongside the existing blog exposed-form alter, so the events filter row always shows the Reset action and matches the other listings. The Reset action's styling is already provided by the theme's views-exposed-filters component. The durable fix belongs upstream in Varbase Components, adding a reset_button_always_show equivalent to components_exposed_form; this is the site-template adaptation.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

  • The Events exposed filter row now shows the Reset action on the unfiltered page, matching the News and Programs listings.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Always show the Reset action on the Events exposed filters, matching the News and Programs listings.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 468f57c9 on 1.0.x
    fix: #3612787 Always show the Reset action on the Events exposed filters
    

  • rajab natshah committed c03141b7 on 1.0.x
    fix: #3612787 Use the Educare navy for exposed-filter and link buttons...

  • rajab natshah committed dbb4295d on 1.0.x
    fix: #3612787 Load the exposed-filters SDC styles only on views exposed...
rajab natshah’s picture

Version: 1.0.x-dev » 1.0.0-alpha1
Assigned: Unassigned » josebc
Issue summary: View changes
Status: Active » Needs review
Issue tags: +vartheme_bs5_educare-1.0.0-alpha1
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.