Closed (fixed)
Project:
Varnish purger
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Apr 2020 at 06:41 UTC
Updated:
9 Jun 2020 at 09:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jayasree.e commentedAdd core_version_requirement: ^8 || ^9. Please review.
Comment #3
gaëlgAccording to drupal-check, the module has no deprecation problem. So, indeed, we only need to update .info.yml file. But also in submodules like varnish_purge_tags.
Comment #4
gaëlgComment #5
sja112 commentedUpdated .info.yml file of module and submodules.
Comment #6
sja112 commentedComment #7
sja112 commentedComment #8
sja112 commentedComment #9
nitesh624Comment #10
nitesh624Comment #11
nitesh624Comment #12
nitesh624update the composer.json and revert th .info.yml
Comment #13
nitesh624Composer require failed because of https://www.drupal.org/project/varnish_purge/issues/2845054.
however it applied successfully on my local machine
Comment #14
nitesh624Comment #15
nitesh624Comment #16
aspilicious commentedYou need to remove the "core" line from the info file.
Comment #17
nitesh624Thanks @aspilicious
Comment #18
nitesh624Comment #19
nitesh624Sorry for the wrong extension of interdiff file in #17
Comment #20
aspilicious commentedThis is OK.
Comment #21
sja112 commentedComment #22
tobybellwood commentedHi,
Just checking to see if there is an aim to get this merged (and hopefully released?) prior to the release of D9 next week, and if there's anything we can do to help out?
We'd obviously prefer not to push out a Drupal9 version of our example project without varnish purging support.
Thanks for your hard work to date!
Comment #25
littlethoughts commentedThanks a lot, included in the new 8.2 release.
Comment #26
naveenvalecha@littlethouhghts,
Any plans to release a new 8.x-1.x release with D9 compatibility?
Comment #27
naveenvalechaFixing the issue status.
Comment #28
idebr commented@littlethoughts What is the reasoning to create a new major branch? It seems 8.x-1.x and 8.x-2.x are perfectly compatible.