Problem/Motivation

height of last inline block item should be consistent with the other items.

Proposed resolution

Override the styling in core/misc/dialog/off-canvas.base.css that removes the padding from the last item

#drupal-off-canvas ul li:last-child, #drupal-off-canvas ol li:last-child {
    padding-bottom: 0;
    border-bottom: none;
  }

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release varbase-9.0.5, varbase_layout_builder-10.0.10

Varbase update type:

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • Fixes the height of the last item in inline blocks list

API changes

  • N/A

Data model changes

  • N/A
CommentFileSizeAuthor
vlb-inline-blocks.png20.68 KBmhawwari
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mhawwari created an issue. See original summary.

mhawwari’s picture

Assigned: mhawwari » Unassigned
Status: Active » Needs review
rajab natshah’s picture

Title: Fix last inline block item styling » Fix last inline block item styling in the Add a new custom block off canvas

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Status: Fixed » Needs review
Issue tags: +varbase-9.0.5, +varbase_layout_builder-10.0.10
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Fixed » Closed (fixed)