Problem/Motivation

The file themes/claro/css/componenets/dialog.css contains the following line which is calling a gif that doesn't exist in themes/claro/images
background-image: url(../../images/loading-small.gif);
This is resulting in a 404 error.

Proposed resolution

I think the problem is caused from importing an old version of claro when compiling. recompiling the scss files could solve the issue.

After the fix

CommentFileSizeAuthor
#18 Edit-layout-for-Test-dev-varbase9c1-after-8.png497.2 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-7.png494.6 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-6.png204.28 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-5.png296.82 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-4.png236.15 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-3.png322.65 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-2.png261.89 KBrajab natshah
#17 Edit-layout-for-Test-dev-varbase9c1-after-1.png349.74 KBrajab natshah
#13 Edit-layout-for-Blog-dev-varbase9c1-edit-uploaded-media.png199.12 KBrajab natshah
#13 Edit-layout-for-Blog-dev-varbase9c1-media-browser.png153.82 KBrajab natshah
#13 Edit-layout-for-Blog-dev-varbase9c1-media-block.png152.64 KBrajab natshah
#13 Edit-layout-for-Blog-dev-varbase9c1.png127.81 KBrajab natshah

Issue fork varbase_layout_builder-3211878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mhawwari created an issue. See original summary.

mhawwari opened merge request !4

mhawwari’s picture

mhawwari commented
Status: Active » Needs review

I recompiled the scss with the latest version of core that no longer references loading-small.gif. It needs to be tested thoroughly.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fix call to non-existent file loading-small.gif » Fix call to non-existent file loading-small.gif by recompiling the scss files for new changes in Claro admin theme
mhawwari’s picture

mhawwari commented

I think to avoid this problem in the future with each core update we can either @import the claro css files directly using vanilla css or import the claro library claro/global-styling directly rather than referencing the scss files.

rajab natshah’s picture

rajab natshah
he/him
commented

Thank you, Hawwari for reporting and patching <3
It's a very good idea. To be synced with Razem.
We could have a bash command file. Or a sub gulp process function to copy that for us on compile.
This may ease the update after Drupal 9.x releases.

rajab natshah’s picture

rajab natshah
he/him
commented

To be committed before the VLB RC release and for Varbase 9.0.0 stable version.
With a fresh recompile from Drupal 9.1.10 4 Jun 2021 at 20:30 EEST

rajab natshah’s picture

rajab natshah
he/him
commented

Maybe Drupal 9.2.0-rc1

rajab natshah’s picture

rajab natshah
he/him
commented

Fantastic.
Thank you Hawwari.

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue tags: +varbase-9.0.0
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new Edit-layout-for-Blog-dev-varbase9c1.png127.81 KB
new Edit-layout-for-Blog-dev-varbase9c1-media-block.png152.64 KB
new Edit-layout-for-Blog-dev-varbase9c1-media-browser.png153.82 KB
new Edit-layout-for-Blog-dev-varbase9c1-edit-uploaded-media.png199.12 KB

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » rajab natshah
Status: Needs work » Active

  • RajabNatshah committed e4e9686 on 10.0.x 
    Issue #3211878: Re-compile Drupal 9.2.0 Claro admin theme to have a...

  • RajabNatshah committed 3135196 on 10.0.x 
    Issue #3211878: Re-compile Drupal 9.2.0 Claro admin theme to have a...
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
StatusFileSize
new Edit-layout-for-Test-dev-varbase9c1-after-1.png349.74 KB
new Edit-layout-for-Test-dev-varbase9c1-after-2.png261.89 KB
new Edit-layout-for-Test-dev-varbase9c1-after-3.png322.65 KB
new Edit-layout-for-Test-dev-varbase9c1-after-4.png236.15 KB
new Edit-layout-for-Test-dev-varbase9c1-after-5.png296.82 KB
new Edit-layout-for-Test-dev-varbase9c1-after-6.png204.28 KB
new Edit-layout-for-Test-dev-varbase9c1-after-7.png494.6 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
StatusFileSize
new Edit-layout-for-Test-dev-varbase9c1-after-8.png497.2 KB

  • RajabNatshah committed 7e0cf00 on 10.0.x 
    Issue #3211878: Re-compile Drupal 9.2.0 Claro admin theme to have a...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.