Comments

firassziedan created an issue. See original summary.

firass.ziedan’s picture

Assigned: firass.ziedan » Unassigned
Status: Active » Needs review
StatusFileSize
new3.29 KB
rajab natshah’s picture

Status: Needs review » Needs work

Thanks, Firas for reporting and patching

If we do have:

status: false

or

status: true

Make sure that CKEditor Entity Embed works.

Needs more testing before we commit.

firass.ziedan’s picture

Status: Needs work » Needs review
StatusFileSize
new829 bytes

I think this way solve the issue

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem

Agreed, it's a better fix for this issue.
only to support the simple text format.
and check for notices. isset() , !empty()

I may do this as a string replace for h1; to empty string.
We could add a HEADER_ONE token to replace with h1 in case some users insisted on having the h1

Thank you :)

rajab natshah’s picture

Assigned: mohammed j. razem » rajab natshah
Status: Needs review » Needs work
rajab natshah’s picture

Title: Remove Heading 1 from WYSIWYG Editor Format » Remove h1 from Paragraph Format in the Full HTML (Rich editor) CKEditor Text format
rajab natshah’s picture

Title: Remove h1 from Paragraph Format in the Full HTML (Rich editor) CKEditor Text format » Remove h1 from Editor formats in the Full HTML (Rich editor) Text format

rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Needs work » Needs review
Issue tags: +varbase-8.8.4
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.