Needs review
Project:
Universally Unique IDentifier
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2016 at 07:56 UTC
Updated:
2 Nov 2017 at 15:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
valthebaldComment #3
skwashd commented@valthebald what are the circumstances where password.inc isn't already included?
Comment #4
valthebald@skwashd well, password.inc is not included during the bootstrap...
My scenario was user entities (node authors) as dependencies of deployed nodes (deploy module pushes to services module on another server)
Comment #5
valthebald@skwashd as you (writefully) mentioned in #2724323: UUID Services update user with pass saved in plain text on database, the most frequently used scenario is deploy module (site A) pushing content to services module (site B).
If user password is hashed by site A using default password.inc, user_hash_password() will not be called.
If user password comes as a clear text, function user_hash_password mush exist, so we need to include password.inc
By the way, if site uses non-default hashing algorithm, hashed password will be rehashed again, breaking user passwords
Comment #6
valthebaldInstead of using hard-coded pattern for hashed password, we can use (swappable) user_needs_new_hash():
with exception for md5()-ed D6 passwords.
Comment #7
osodani commentedRan into this issue today, #6 solved it for us