Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I noticed a bug in uuid_entities_features_export_render: the first argument of this function is $module_name. On line 106, there is the following code:
foreach (module_implements($hook) as $module_name) {
In some cases, this code actually replaces the main $module_name variable, causing error messages to be displayed. I will provide a patch to fix this issue.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1628456-module_name-1.patch | 832 bytes | guillaumev |
Comments
Comment #1
guillaumev CreditAttribution: guillaumev commentedHere is the patch.
Comment #2
matthandThis patch corrected an error I was receiving after importing a feature. Thanks guillaumev!
Comment #3
matthandThis patch is a solid bug fix and is safe to apply. Can we get it on the docket to be pulled into the repository? Thank you!
Comment #4
skwashd CreditAttribution: skwashd at Dave Hall Consulting commented@guillaumev or @BullMoose are you able to provide test cases to verify the bug and the fix?
Comment #5
matthand@skwashd Sorry, I currently have no time to build out test cases for such a simple bug fix. Have you reviewed the patch at all before asking for more info?
Comment #6
skwashd CreditAttribution: skwashd at Dave Hall Consulting commented@BullMouse, I did review it. Looks good to me. We try to get test coverage for all bug fixes.
Comment #7
matthandI can describe my test case a bit now, possibly write a real test later.
Bug triggers following warnings and notices:
There's also a bug in Entity UUID that needs to be patched before attempting this workflow. But the warnings and notices are related to UUID and corrected by applying the patch from comment #1: https://www.drupal.org/files/1628456-module_name-1.patch .
Sorry for being so general. It's all I have time for. Thanks!