Problem/Motivation

We were seeing some fieldsets not displaying, and there was "display:none" attribute on them. We discovered that the culprit was the template "element/details.html.twig" and some classes were not getting set on the element because the classes were hardcoded.

Steps to reproduce

Hard to reproduce - was a very random side effect for us. We were using the smart date module, and noticed the date fields would not show in this theme when editing a node with a smart_date field. Strange this was not a direct effect of the template, but a side effect.

Proposed resolution

Add classes with the .addClass() method so existing classes are maintained.

Remaining tasks

Review

User interface changes

None

API changes

None

Data model changes

None

Issue fork uswds-3541604

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_earnest created an issue. See original summary.

scott_earnest’s picture

scott_earnest commented
Title: Random fieldsets get a display none » Adds classes with addClass on details element
scott_earnest’s picture

scott_earnest commented
Title: Adds classes with addClass on details element » Add classes with addClass on details element

scott_earnest opened merge request !26

scott_earnest’s picture

scott_earnest commented
Status: Active » Needs review
scott_earnest’s picture

scott_earnest commented
Assigned: scott_earnest » Unassigned

jrglasgow made their first commit to this issue’s fork.

jrglasgow’s picture

jrglasgow commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.