While running a site through Axe Devtools we received the error: Section usa-hero must be contained within landmarks. Digging into this online I found: https://dequeuniversity.com/rules/axe/3.5/region?application=AxeChrome

The page.html.twig template for USWDS v2 currently places the usa-hero block outside of any landmarks. The markup looks like so:

</header>

{% if page.hero %}
     <section class="usa-hero">
  {{ page.hero }}
</section>
{% endif %}

 <main class="usa-section" id="main-content">

But I think this tag should technically be living within the tag as seen here: https://federalist-3b6ba08e-0df4-44c9-ac73-6fc193b0e19c.app.cloud.gov/pr...

Issue fork uswds-3207695

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

JayDarnell created an issue. See original summary.

jrglasgow made their first commit to this issue’s fork.

  • jrglasgow committed 507e354 on 8.x-2.x
    git commit -m 'Issue #3207695 by jrglasgow: Section usa-hero must be...
jrglasgow’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.