Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lolandese’s picture

Status: Active » Needs review
FileSize
4 KB

Patch provided that adds a submodule 'Uptime test' that:

  • adds test_dependencies[] = uptime_widget_test to the .info to be recognized by simplytest.me (should be enabled automatically)
  • creates some admin quick links in the navigation menu
  • save some new settings for testing
  • reverts to previous settings on uninstall.
lolandese’s picture

Committed. Tested by using http://simplytest.me/project/uptime_widget/7.x-1.x

Simplytest.me uses git, thus our test module is in the module list (under 'Development') even before the commit has been pacckaged by d.o.

Our test module is not enabled by default, thus leaving status "needs work".

lolandese’s picture

Projects specified with test_dependency will only be automatically downloaded (if they are external), but not enabled .

We still have to make use of a patch to add the real dependency to the main .info file.

Simplytest.me's maintainer indicated this behavior might change in the future.

Added mini patch to add uptime_widget_test as a hard dependency, so it will get enabled.

lolandese’s picture

In this particular case we also need cron to run. A patch to the .install file to both enable the test module and run cron is the easiest.

lolandese’s picture

lolandese’s picture

lolandese’s picture

Status: Needs review » Needs work

One first test simplytest.me hanged on 67% of installation. Another test this morning went without problems.

Needs to remove activation link to simpletest.me on the sample node. If we see that, we are already in the demo.

lolandese’s picture

Attached patch removes some double cron runs. That might be reason for longer or hanging install of the simplytest.me. Also from the latest patch in #7 we can remove cron run.

Furthermore we improved the content of the created node.

lolandese’s picture

lolandese’s picture

FileSize
541 bytes

And a new patch, not to be committed but only for deploy on simplytest.me.

lolandese’s picture

lolandese’s picture

FileSize
709 bytes

Well, we forgot that the cron was needed also to update the uptime ratio.

New patch.

lolandese’s picture

lolandese’s picture

Status: Needs review » Fixed
lolandese’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lolandese’s picture

Added simplytest_dependencies[] = uptime_widget_test to the .info file. Committed.

After a great enhancement on Simplytest.me this now results in the demo sub-module being enabled without having to use a patch to do that.

http://simplytest.me/project/uptime_widget/7.x-1.x?add[]=pagerank_widget

lolandese’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
14.51 KB

Removed PageRank Widget from the demo that has its own demo now.

lolandese’s picture

FileSize
18.43 KB
lolandese’s picture

FileSize
18.47 KB

lolandese’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.