Support generating Code Quality JSON reports (for GitLab CI integration)

Can you show a sample screenshot from this command? Also do you have others who could help verify/review the code? I don't believe I have a way to check this.

Reviewed the code as well. Looks pretty reasonable even without knowing gitlab code quality reports.

+++ b/src/Commands/UpgradeStatusCommands.php
@@ -122,6 +122,105 @@ class UpgradeStatusCommands extends DrushCommands {
+            $description = $name . ' - ' . $error['message'];

How does this show up on the UI? Is it possible to dive deeper into this? The extension name and error is not necessarily a unique identifier, multiple copies of the same description could appear with unique fingerprints.

Wow, there is also #3391323: Add options to provide drush analyze output in JSON and CSV, but this may guide the JSON format better to align with an industry solution :)

Also #3152580: Add UI option to export Upgrade Status results as CSV is somewhat similar.

Docs link is a 404. I think it's moved to https://docs.gitlab.com/ee/ci/testing/code_quality.html

Just now I merged #3175323: The analyze command should report proper exit code so now there is --format support on the analyze command where this should go instead of its own command.

Also I added drush command testing there which this should extend.

Finally, I looked at the current GitLab CI docs at https://docs.gitlab.com/ee/ci/testing/code_quality.html and Code Climate docs at https://github.com/codeclimate/platform/blob/master/spec/analyzers/SPEC.... (which the GitLab CI solution is based on) and it appears like you added the category element as raw value of Upgrade Status category, which is not supported by either. Code Climate does not require the fingerprint but GitLab CI appears so, so that looks good. However both require a check_name defined that is not in the patch. So that is still to be done. I think it could either be "Upgrade Status" or we can lightly expand the analyzers in Upgrade Status to give a bit more info, so we can identify the checker at least (eg. PHPStan, Info/composer checker, CSS deprecation checker, etc). I don't know how specific are those checker names usually with other tools.

Will try to push this forward.

Moved code from patch #4 into the analyze Drush command as requested in #11.

Added format test. It would be good to also add integration test that would actually scan one of the test modules and throw that into GitLab to consume. However the check would really only be done by a human to make sure it's parse and displayed in the GitLab UI, so not sure how much value in it. Could be a follow up.

Added all required by the spec fields.

Aw, such a perfect update! Thanks for being so thorough! I would love to get this and give it some publicity. How would someone go about integrating this into their drupal.org modules's CI workflow and optionally if they have their own gitlab (or github) CI setup, how would this be possible to integrate there?

Woot, thanks!

Trying this out now on #3443986: Test code quality analysis integration of Upgrade Status.