Problem/Motivation

We are checking info.yml compatibility but do not check composer.json compatibility yet. While composer.json is optional, if a project does have a composer.json and it is not compatible with Drupal 9 then it will not be compatible for people using composer.

Proposed resolution

Add check. Add tests.

Remaining tasks

Do it.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3123996-3.patch3.05 KBgábor hojtsy
#2 3123996.patch2.55 KBgábor hojtsy

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new 3123996.patch2.55 KB

Quick patch. No tests yet. But this should not break existing testing at least.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3123996-3.patch3.05 KB

Fixed a bunch of problems with this. I tried to find where the info.yml checking is tested to add testing for this there, but there was none. Duh. I will go ahead and commit this for now as well and hopefully get back to rework tests in #3100308: Make Upgrade Status tests Drupal 9 compatible where we'll need to rework them anyway.

  • Gábor Hojtsy committed 8ff4101 on 8.x-2.x 
    Issue #3123996 by Gábor Hojtsy: Check if composer.json is not Drupal 9...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Check if composer.json is not Drupal 9 compatible » Check if composer.json is not Drupal 9 compatible, if it exists
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.