Problem/Motivation

When retrieving the segments to define visibility for it, we use the default get segments call this has a limit of 50 segments, so we do not get all segments we have to choose from.

Steps to reproduce

Have unomi with more then 50 segments, see that you can not find them all.

Proposed resolution

Use the size parameter.

Remaining tasks

Make sure to use a new release from unomi-sdk-php since without this https://gitlab.com/dropsolid/unomi-sdk-php/-/merge_requests/4 the sdk actually does not support setting the size parameter.
When not having that included, nothing changes, so it's not a breaking change to merge this before an updated sdk is released, only does not fix anything.

if possible this would also be good to have in the 4.x version (and have a new release for both 4.x and 5.x)

CommentFileSizeAuthor
#13 unomi-sdk-query-param-fix.patch858 bytesstevenx
#13 Bildschirmfoto 2025-05-22 um 19.36.37.png82.95 KBstevenx

Issue fork unomi-3498788

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mallezie created an issue. See original summary.

mallezie opened merge request !17

mallezie opened merge request !18

mallezie closed merge request !18

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Status: Active » Needs review

MR 17 is the correct one. https://git.drupalcode.org/project/unomi/-/merge_requests/17

grayle changed the visibility of the branch 3498788-cannot-select-all to hidden.

grayle changed the visibility of the branch 3498788-cannot-select-all to active.

grayle’s picture

grayle commented

I'd also update the requirement for the sdk.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented

And done that, now that there is a new release there.

  • grayle committed 47e17bba on 5.x authored by mallezie 
    Issue #3498788 by mallezie, grayle: Cannot select all segments when...
grayle’s picture

grayle commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stevenx’s picture

stevenx commented
StatusFileSize
new Bildschirmfoto 2025-05-22 um 19.36.37.png82.95 KB
new unomi-sdk-query-param-fix.patch858 bytes

Its not fixed for basic auth, i wrote a patch for the unomi php sdk (https://gitlab.com/dropsolid/unomi-sdk-php),
not sure how to gain permission to send a commit there...

would be nice if you review it and merge it.

now you see more than 50 segments.

thanks

Steven

"patches": {
"dropsolid/unomi-sdk-php": {
"Fix URL parameter application for Basic Auth (no provider) requests": "patches/unomi-sdk-query-param-fix.patch"
}
},

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented

@steven

Thanks for the patch, created a MR from it here. https://gitlab.com/dropsolid/unomi-sdk-php/-/merge_requests/5

I'll check with my colleagues for a new release for the sdk.