Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi,
From my testing, it seems that unlimited_css.module doesn't work with conditional_styles.module.
I have a theme that optionally uses conditional_styles.module to insert a conditional IE stylesheet (but you can use Zen.theme as a test theme for this).
When I have both modules enabled, this stylesheet doesn't appear in the rendered HTML source. When I have one of these modules enabled, the stylesheet does appear.
Not sure where the responsiblity lies, but I'll let you decide whether to pass this onto the conditional_styles.module maintainer.
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#3 | unlimited_css-457124-3.patch | 734 bytes | BWPanda |
Comments
Comment #1
bengtan CreditAttribution: bengtan commentedComment #2
BWPanda CreditAttribution: BWPanda commentedI can confirm this bug.
I'll have a read through the code to try and work out what's wrong and see if I can create a patch for it...
Comment #3
BWPanda CreditAttribution: BWPanda commentedHere you go. A rudimentary patch that simply adds the value of
$vars['conditional_styles']
to the$styles variable
.Ideally you'd create a separate
<style>
element, surrounded by conditional comments, that @imports the various IE-specific stylesheets. But I don't see how this would be possible with the current setup...Also, I'd recommend removing the restriction of only having 15 imports per
<style>
as someone may have lots of conditional stylesheets which could breach the limit of 30. Not likely, but possible...Comment #4
ademarco CreditAttribution: ademarco commentedThanks for the patch BWPanda, I'll review it during the next days...
Comment #5
ademarco CreditAttribution: ademarco commentedPatch applied. Thanks for patching.