Problem/Motivation

When attempting to unit test a widget which extends the StringTextfieldWidget the traditional method of mocking the string translation service fails and an error is produced Call to undefined function Drupal\Core\Field\Plugin\Field\FieldWidget\t().

Proposed resolution

PluginBase is using StringTranslationTrait but many of the child plugins are not utilizing it properly. Use $this->t() instead of t() for string translation calls for all classes extending PluginBase.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3188650-10.patch2.05 KBnitin_lama
#7 patches.png208.58 KBchaitanyadessai
#7 3188650-7.patch62.06 KBchaitanyadessai
#5 replace-t-with-this-t-3188650-2.patch47.73 KBnovchuk.v
#4 replace-t-with-this-t-3188650-2.patch47.73 KBnovchuk.v
#2 replace-t-with-this-t-3188650.patch47.27 KBnovchuk.v

Issue fork ultimate_cron-3188650

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

novchuk.v created an issue. See original summary.

novchuk.v’s picture

novchuk.v commented
Assigned: novchuk.v » Unassigned
Status: Active » Needs review
StatusFileSize
new replace-t-with-this-t-3188650.patch47.27 KB

Status: Needs review » Needs work

The last submitted patch, 2: replace-t-with-this-t-3188650.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

novchuk.v’s picture

novchuk.v commented
StatusFileSize
new replace-t-with-this-t-3188650-2.patch47.73 KB
novchuk.v’s picture

novchuk.v commented
Status: Needs work » Needs review
StatusFileSize
new replace-t-with-this-t-3188650-2.patch47.73 KB

Status: Needs review » Needs work

The last submitted patch, 5: replace-t-with-this-t-3188650-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chaitanyadessai’s picture

chaitanyadessai commented
Status: Needs work » Needs review
StatusFileSize
new 3188650-7.patch62.06 KB
new patches.png208.58 KB

Please review patch.
Replaced t() with $this->t() in all plugins

Status: Needs review » Needs work

The last submitted patch, 7: 3188650-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
StatusFileSize
new 3188650-10.patch2.05 KB

Providing updated patch. i think we only need to use StringTranslationTrait for classes which extends PluginBase.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review. Thanks.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
solideogloria’s picture

solideogloria commented
Status: Needs review » Needs work
Issue tags: +Novice

The patch should be converted to a merge request.

aryan singh’s picture

aryan singh commented

Working...

aryan singh opened merge request !78

aryan singh’s picture

aryan singh commented
Status: Needs work » Needs review

liam morland made their first commit to this issue’s fork.

solideogloria’s picture

solideogloria commented
Status: Needs review » Needs work

There are definitely other classes that can use $this->t(). CronJobForm is one, since it extends EntityForm. I also think it should StringTranslationTrait could be used in CronJobDiscovery and other such classes. Any class using dependency injection should use it.

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
solideogloria’s picture

solideogloria commented
Related issues: +#3188650: Replace t() with $this->t() in all classes
solideogloria’s picture

solideogloria commented
Related issues: -#3188650: Replace t() with $this->t() in all classes +#3131660: t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
solideogloria’s picture

solideogloria commented
Title: Replace t() with $this->t() in all plugins » Replace t() with $this->t() in all classes
solideogloria’s picture

solideogloria commented
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Conflicts with the short array syntax issue.

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review

Rebased

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

reviewed.

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review

  • berdir committed 3d63d467 on 8.x-2.x authored by aryan singh 
    feat: #3188650 Replace t() with $this->t() in all classes

By:...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

solideogloria’s picture

solideogloria commented

@berdir I'm not credited in the contribution record, for some reason, despite committing multiple times. Can you fix that, please?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I updated that.

solideogloria’s picture

solideogloria commented

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.