Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Found an error when using it with php 7.1
Error: Unsupported operand types in UltimateCronQueueSettings->cron_alter() (line 188 of /modules/contrib/ultimate_cron/plugins/ultimate_cron/settings/queue.class.php).
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff_2944641_2-6.txt | 1.21 KB | alexdmccabe |
#6 | ultimate_cron-unsupported-operand-types-2944641-6.patch | 1.21 KB | alexdmccabe |
#2 | unsupported-operand-types-2944641-1.patch | 663 bytes | david.lopez |
Comments
Comment #2
david.lopez CreditAttribution: david.lopez at Liip for FREITAG lab. AG commentedPatch attached for review
Comment #3
joelstein CreditAttribution: joelstein at On Fire Media commentedI encountered this same bug, but after patching it I now see this warning (which is better than an error):
Comment #4
arnested CreditAttribution: arnested at Reload commentedThank you for the patch, david.lopez, and thank you for the review, joelstein.
I think this indicates we have to find a root cause of the none existing
$jobs['ultimate_cron_plugin_settings_queue_cleanup']->settings
.Comment #5
AlexKirienko CreditAttribution: AlexKirienko at Adyax commentedWe faced similar issue from time to time on deployment.
We have a lot of features and use CI for deployment which revert features.
Fixed with command
drush rr
Patch #1 was applied. I will test it for a while.
Comment #6
alexdmccabeI think it might be because it was never defined anywhere in the first place. I'm using version 7.x-2.8:
Digging through the git history with
git grep "ultimate_cron_plugin_settings_queue_cleanup" $(git rev-list --all)
gives me pretty much the same story:That's just the first two commits, but it's the same all the way down the list.
What was this job originally supposed to do? It seems like it was never fully fleshed out in the first place. Would it be simpler to just remove it, since it can't possibly be working anyway?
Patch to make that change attached, but I'm not sure what to make of the if statement at the beginning of the method. Should it also be removed?