The schedule settings form is currently blank due to SchedulerSettingsForm::buildForm() not returning the form array.

CommentFileSizeAuthor
#5 scheduler_settings_form-2923922-5.patch2.87 KBreflie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rwohleb created an issue. See original summary.

rwohleb’s picture

rwohleb
he/him
Primary language English
CreditAttribution: rwohleb at George Lucas Educational Foundation commented

From this:

parent::buildForm($form, $form_state);

To this:

return parent::buildForm($form, $form_state);
gge’s picture

gge CreditAttribution: gge commented

@rwohleb

I've found parent::buildForm($form, $form_state); in ultimateultimate_cron/src/FormSchedulerSettingsForm.php. However after changing that line to return parent::buildForm($form, $form_state); the scheduler settings do appear but the settings but can't be saved. The console shows this error: An invalid form control with name='simple[rule]' is not focusable.

How can you save the settings?

Thanks

reflie’s picture

reflie CreditAttribution: reflie as a volunteer and at AnyforSoft, Drupal Ukraine Community commented
Assigned: Unassigned » reflie
Issue tags: +LutskGSW18
reflie’s picture

reflie CreditAttribution: reflie as a volunteer and at AnyforSoft, Drupal Ukraine Community commented
Assigned: reflie » Unassigned
Status: Active » Needs review
FileSize
scheduler_settings_form-2923922-5.patch2.87 KB

Here is a patch. It fixes the problem with blank scheduler settings from, a problem with saving values in the config and loading them from it. Also I commented "element_validate" function (like in Crontab.php file) as it isn't ready yet and produces warnings.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Thanks but all those settings are currently pretty much non-functional and ignored. See #2692781: Make global setting ui dynamic and use it, doesn't really make sense to fix some part about it when they don't do anything.

reflie’s picture

reflie CreditAttribution: reflie as a volunteer and at AnyforSoft, Drupal Ukraine Community commented

Oh, I didn't notice this issue.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

FYI its still blank in latest release.

dmegatool’s picture

dmegatool CreditAttribution: dmegatool commented

Yeah just installed for the first time and the form is still blank. Thx @reflie for the patch in comment #5

lhridley’s picture

lhridley CreditAttribution: lhridley as a volunteer and at Interpersonal Frequency commented
Status: Needs review » Needs work

Marking Needs Work. Patch failed to apply.

brooke_heaton’s picture

brooke_heaton CreditAttribution: brooke_heaton commented

Patch #5 is working for me on 8.x-2.0-alpha5. Applies fine.

brooke_heaton’s picture

brooke_heaton CreditAttribution: brooke_heaton commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Was this fixed in another issue? I'm able to use the latest alpha release just fine.