Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To support drush 9.x we need to port the drush commands to the new structure.
Comment | File | Size | Author |
---|---|---|---|
#21 | 2912724-21.patch | 13.06 KB | Berdir |
| |||
#17 | 2912724-17.patch | 13.29 KB | rgpublic |
| |||
#16 | 2912724-16.patch | 6.06 KB | gchauhan |
#13 | 2912724-13.patch | 13.13 KB | avogler |
| |||
#10 | interdiff-8-9.txt | 704 bytes | GaëlG |
Comments
Comment #2
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedComment #3
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedInitial port of drush commands to drush 9 syntax.
Comment #4
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedComment #6
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedoops uploaded wrong patch. This is the right one.
Comment #7
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedComment #8
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedI've updated the patch to move the drush command service to drush.services.yml to follow best practices.
Comment #10
GaëlGThanks kmoll! The previous patch did not work for "drush cron-run" (all jobs). Here's an update.
Comment #11
avogler CreditAttribution: avogler commentedI manually tested the patch and it works for me. As far as I can tell the code looks solid.
+RTBC
Comment #12
GaëlGComment #13
avogler CreditAttribution: avogler commentedSorry to reopen, but I found a minor bug. The --force option on cron-run was not working as $option was overwritten with $option['option]. I have attached a corrected patch.
Comment #14
Christopher Riley CreditAttribution: Christopher Riley commentedAny word on getting this committed its been a couple of months and no word on this.
Comment #15
BerdirThis copies the known an existing bugs from the current commands.
This doesn't make sense and it skips a ton of logic by not going through the runner.
Ther is no need for this option,use the core cron command instead.
The 9.x switch is a good moment to remove support for not passing a $name. just point reference the core command instead in the documentation.
Comment #16
gchauhan CreditAttribution: gchauhan as a volunteer and at OpenSense Labs for DrupalFit commentedHi all,
Adding the patch for drush9 commands. I have followed this blog.
Comment #17
rgpublicOk, #16 was of course trash, so I'm building on #13. I've added Berdir's wishes from #15. Do we need anything else to get this committed?
Comment #18
rgpublicCome to think of it, we should probably remove the second @usage annotation, right? I wonder: Do we still need the options at all? If yes, we might need a better example, because the --options=thread=1 doesnt make much sense to me in connection with a single cronjob run.
Comment #19
jsst CreditAttribution: jsst commentedCould you explain how you intend to make it possible to run jobs in parallel?
For example, I would like to:
- run some import jobs in thread 1
- run some export jobs in thread 2
- run all other core jobs seperately
This patch currently seems unable to run threads, and when using 'core:cron' to run all other jobs, won't it run my import/export jobs as well? I don't want the core jobs to be waiting for imports!
Comment #20
rgpublicI'm now thinking this patch should be comitted as-is. Perfectionism all good and well, but in fact we don't have any usable ultimate_cron drush commands with Drush9 for over 2 years now. I'm using the patch without any major problems for quite some time. I think it's still better to be able to start cronjobs from CLI *at all* - even without any cool threading capabilities etc.
Comment #21
BerdirRerolled.
Comment #23
BerdirRemoved the second usage example and committed. If someone needs other options they can add them later on.