There are several issues with the configuration forms such as the settings not saving correctly, required setting not being applied properly with state, etc.

CommentFileSizeAuthor
#2 ultimate_cron-2889309-2.patch10.34 KBbadjava
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

badjava created an issue. See original summary.

badjava’s picture

badjava CreditAttribution: badjava at Metasun for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
ultimate_cron-2889309-2.patch10.34 KB

Here is the patch which should fix all of the settings form issues so that you can save all the values and they are displayed correctly as well. I also updated the arrays so that they were consistent with [] instead of array() and a few other minor coding style changes.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Thanks for the patch.

Mixing coding style fixes and functional fixes is problematic. We have an existing issue about the fact that the global settings are currently completely unused anyway: #2692781: Make global setting ui dynamic and use it. Maybe you can help bringing that forward?

badjava’s picture

badjava CreditAttribution: badjava at Metasun for Pfizer, Inc. commented
Status: Needs review » Closed (won't fix)