Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi jthorson,
long time i didn't talk with you, i hope you are going well :)
I have a problem on match page with url => ult/game/nid, the comments aren't displaying below nodes, if i change the url by /nid the comments are displaying, how can i fix that ?
Thank you for your answer :)
Comments
Comment #1
jthorson CreditAttribution: jthorson commentedHmmm ... I don't see anything that should cause this, so long as the comment output is included in your page.tpl.php template.
Just to rule out the obvious, if you switch to one of the core themes and clear all caches, do the comments appear?
Alternatively, if your theme outputs comments in the node.tpl.php file instead of page.tpl.php, then you'll need to copy the code which outputs comments into the module's node-ult_game.tpl.php file (located at /modules/ult_matches/includes/templates/node-ult_game.tpl.php).
Comment #2
MasterChief CreditAttribution: MasterChief commentedI just tried with garland and Minnelli core themes and same result, so it's a problem with ult :(
Another idea?
Comment #3
MasterChief CreditAttribution: MasterChief commentedCan you try to see if you have the same problem ?
You need to activate comments on the node type of course (^_^)
Comment #4
jthorson CreditAttribution: jthorson commentedThis is related to one of the architectural limitations with the system ... my unfortunate decision to 'rebuild' each page instead of simply leveraging the existing nodes. If you view the node/nid page associated with a given game instead of the ult/game/gameid page, you do get the comments.
The (untested) resolution for this should be to change the 'ult/game/nid' menu callbacks, defined on lines 145 and 155 of ult_matches.module, from 'node_view' to 'node_page_view'.
Comment #5
MasterChief CreditAttribution: MasterChief commentedGreat it's working !
Thank you very much.
PS:
What do you plan for the future with drupal 7 with ult now that tournament module is developped again by drupaljoe ? Each on his side or some integration with each other ? I am not planing to upgrade on drupal 7 soon, but it's good to know (^_^)
Comment #6
jthorson CreditAttribution: jthorson commentedI have no plans for porting ULT to Drupal 7 ... rather, I want to take the lessons learned from ULT and put them to use as part of a unified Sports API for Drupal. My plans on this front match up very closely with the architecture of the 'Tourney' module (different project than 'tournament'!) ... so I suspect I'll be using it for a basis of my integration work.
It doesn't really make sense for Tourney, Tournament, ULT, and Sports API to be pursued independently ... but the testing infrastructure and drupal.org upgrade projects are going to mean I don't get back to trying to coordinate these disparate efforts anytime before DrupalCon.