CommentFileSizeAuthor
#2 2895105-2.patch649 bytesRajab Natshah
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajabNatshah created an issue. See original summary.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah as a volunteer and at Vardot, Webship commented
FileSize
2895105-2.patch649 bytes
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah as a volunteer and at Vardot, Webship commented
Assigned: Rajab Natshah » Unassigned
Status: Needs work » Needs review

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented
Status: Needs review » Fixed
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah as a volunteer and at Webship commented

Hi Richard,

Not sure if we need to change too
-uikit_blog.settings:
+uikit_admin.settings:

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented
Title: Fixed uikit_admin schema name » Various typos throughout code
Status: Fixed » Needs work

Yeah, when creating the 8.x-2.x branch I used the UIkit Blog files as a template. I should do a recursive search to make sure nothing else was skipped over. Thanks

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah as a volunteer and at Webship commented

Thank you Richard,

I'm using UIkit Admin theme as a base theme in Webship, and Cucumber profiles.

Not sure if some of the configurations will not be inherited to the sub theme.

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented
Status: Needs work » Fixed

Sub-themes should still inherit configurations since we're not defining anything besides the label.

Fixed the additional typo in uikit.schema.yml

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.