Problem/Motivation

Use new stories flexibility to improve components examples by reproducing the same examples as the Bootstrap documentation which was not possible before due to need of different combination of props and slots in preview.

But first, ensure stories look the same as UIP1 with #3485906: Restore the UIP1 preview templates. Remove create_attribute calls when not needed. Fix PHP notice. Fix Components library.

DONE:

  • accordion
  • alert
  • badge
  • blockquote
  • breadcrumb
  • button
  • button group
  • button toolbar
  • card
  • card group
  • card overlay
  • carousel
  • close button
  • dropdown
  • figure
  • grid row
  • list
  • list group
  • modal
  • nav
  • navbar
  • navbar nav
  • offcanvas
  • pagination
  • progress/progress stacked
  • spinner
  • table
  • toast/toast container

Create change records when MR will be validated.

Issue fork ui_suite_bootstrap-3485834

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
Parent issue: #3412076: [5.1.0] Conversion to SDC & UI Patterns 2.x » #3485906: Restore the UIP1 preview templates. Remove create_attribute calls when not needed. Fix PHP notice. Fix Components library.
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Postponed
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Postponed » Active
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

grimreaper opened merge request !273

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Found a missing case on Carousel, https://getbootstrap.com/docs/5.3/components/carousel/#autoplaying-carou...

When the ride option is set to true, rather than carousel, the carousel won’t automatically start to cycle on page load. Instead, it will only start after the first user interaction.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

Found a problem with blockquote in card.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
Status: Active » Needs work

Found a missing case with navbar.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

I have created the upstream issue: https://github.com/twbs/bootstrap/issues/41292

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Needs work » Needs review
pdureau’s picture

pdureau commented
Assigned: pdureau » grimreaper
Status: Needs review » Reviewed & tested by the community

  • grimreaper committed c0ec6e39 on 5.1.x 
    Issue #3485834 by grimreaper, pdureau: Use new stories flexibility to...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.