Problem/Motivation

- Add a prop dropdown_id on nav.
- Search Twig syntax to loop without having the unused loop variable slide in carousel.

Issue fork ui_suite_bootstrap-3485674

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grimreaper created an issue. See original summary.

grimreaper opened merge request !219

grimreaper credited pdureau.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Active » Needs review
pdureau’s picture

pdureau commented
Status: Needs review » Needs work

Lets use range() function instead of the .. built-in operator because:

  • .. is just syntactic sugar for the range() function. So, 1..items|length is the same as range(1, items|length), but without the possibility of adding a step
  • .. doesn't' exist in Jinja and Nunjucks, but range() function does.
  • Using a function will let us benefit for a check on function parameters we plan to introduce later

See also: #3485967: Validator: warnign if `..` operator is found

pdureau’s picture

pdureau commented
Assigned: pdureau » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Needs work » Needs review

MR updated.

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.