Problem/Motivation

#3412076: [5.1.0] Conversion to SDC & UI Patterns 2.x doesn't work well with UI Patterns 2 (fatal errors!) currently because we still use the #type => markup which was removed in Drupal 8.0: https://www.drupal.org/node/2036237

$ grep -r type.*markup components
components/toast/toast.component.yml:          type: markup
components/blockquote/blockquote.component.yml:          type: markup
components/toast_container/toast_container.component.yml:                type: markup
components/toast_container/toast_container.component.yml:                type: markup
components/toast_container/toast_container.component.yml:                type: markup
components/toast_container/toast_container.component.yml:                type: markup
components/toast_container/toast_container.component.yml:                type: markup

Proposed resolution

Remove type: markup from component preview.

Make change in UI Patterns 1.
New UI Patterns 1 release.
Increase requirements in ui_suite_bootstrap

CommentFileSizeAuthor
#3 remove-obsolete-type-3480414.patch2.62 KBananya.k

Issue fork ui_suite_bootstrap-3480414

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

ananya.k’s picture

ananya.k commented
Assigned: Unassigned » ananya.k
ananya.k’s picture

ananya.k commented
Assigned: ananya.k » Unassigned
Status: Active » Needs review
StatusFileSize
new remove-obsolete-type-3480414.patch2.62 KB

I have made some changes. Please refer to attached patch.

grimreaper made their first commit to this issue’s fork.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Needs work

Hi,

Please create a MR instead of a patch.

Only "type: markup" should be removed, not the markup.

ananya.k changed the visibility of the branch 3480414-remove-obsolete-type to hidden.

ananya.k changed the visibility of the branch 3480414-remove-obsolete-type to active.

ananya.k’s picture

ananya.k commented
Assigned: Unassigned » ananya.k

ananya.k opened merge request !210

ananya.k’s picture

ananya.k commented
Assigned: ananya.k » Unassigned
Status: Needs work » Needs review

Please review this MR.

pdureau’s picture

pdureau commented
Status: Needs review » Needs work

See "If you remove the dash ("-") it needs to be intentional (you tested it, and it is not necessary) and the indentation of the block may need to be changed too." comments

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Needs work » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: pdureau » grimreaper
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Parent issue: » #3481479: Patterns preview: handle markup
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Postponed

Postponed until parent issue is merged

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Postponed » Fixed

  • grimreaper committed c0f67ef6 on 5.0.x authored by ananya.k 
    Issue #3480414 by grimreaper, ananya.k, pdureau: Remove obsolete #type...
ananya.k’s picture

ananya.k commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.