Problem/Motivation

https://getbootstrap.com/docs/5.3/components/dropdowns/#menu-alignment is not implemented in the dropdown component. It can be useful for dropdowns in mobile.

Need to check if other dropdown features are missing.

CommentFileSizeAuthor
#5 ui_suite_bootstrap-dropdown_menu_alignment-3426475-5.patch4.27 KBgrimreaper

Issue fork ui_suite_bootstrap-3426475

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Currently by having a content prop of type links, this prevent features like https://getbootstrap.com/docs/5.3/components/dropdowns/#forms

I guess in some navigation menu / header, with custom code to generate such dropdowns, this can be useful to be able to support that. For login, search forms.

Grimreaper opened merge request !168

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
StatusFileSize
new ui_suite_bootstrap-dropdown_menu_alignment-3426475-5.patch4.27 KB

Uploading patch for Composer usage.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Active » Needs work

@pdureau, can you please give a look at the MR and also about comment 3?

pdureau’s picture

pdureau commented

Currently by having a content prop of type links, this prevent features like https://getbootstrap.com/docs/5.3/components/dropdowns/#forms

I would prefer to keep a convenient data structure with the links prop type, at the cost of not implementing every fetaure of this component.

pdureau’s picture

pdureau commented
Assigned: pdureau » grimreaper

{% set dropdown_menu_attributes = dropdown_menu_start ? dropdown_menu_attributes.addClass(dropdown_menu_start) : dropdown_menu_attributes %}

Why do we need to test dropdown_menu_start ? What would be the result of {% set dropdown_menu_attributes = dropdown_menu_attributes.addClass(dropdown_menu_start) %} if dropdown_menu_start is empty or not defined?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau

Ready to merge.

Ok for you @pdureau?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review
pdureau’s picture

pdureau commented
Status: Needs review » Reviewed & tested by the community

Not tested but reviewed

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned

  • Grimreaper committed 89c14e15 on 5.0.x 
    Issue #3426475 by Grimreaper, pdureau: Dropdown, implements menu...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.