Problem/Motivation

There are some differences between expected variables ("attributes", slots, props, declared in templates, macro arguments...) and callables (provided by Twig, defined as macro) and variables used in templates (printed, tested, altered...)

We need to align them.

Proposed resolution

Bootstrap 5:

  • table: table_classes is used in template but not defined

Let's do a MR.

Bootstrap 4:

  • alert: alert is used in templates but never defined >> it must be a string instead
  • blockquote: variants are defined but not managed in templates >> remove them
  • dropdown: split is used in template but never defined >>a leftover, let's remove it
  • figure: no variant in definition, but variant management in template
  • table: table_classes is used in template but not defined

Let's commit directly.

API changes

Nothing, because we are lucky: we may change only templates and not the definitions.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

  • pdureau committed fb6da33b on 4.0.x
    Issue #3405021 by pdureau: Align expected variables and variables used...

Grimreaper made their first commit to this issue’s fork.

grimreaper’s picture

Assigned: pdureau » grimreaper

I will do the BS5 part.

  • Grimreaper committed dacd2735 on 5.0.x
    Issue #3405021 by Grimreaper, pdureau: Align expected variables and...
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.