Problem/Motivation

Olivero:

Bootstrap 3:

UI Suite Bootstrap 5:

Details:
- panel in Bootstrap 3 https://getbootstrap.com/docs/3.4/components/#panels
- card + collapse from Bootstrap 4 https://getbootstrap.com/docs/4.6/migration/#panels

Regarding the look in Olivero:
- Fieldsets => Card
- Details => Accordion

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

grimreaper’s picture

Even if Drupal does not have "inline" label for fieldset as of https://getbootstrap.com/docs/5.2/forms/layout/#horizontal-form, I will try to support that.

grimreaper’s picture

grimreaper’s picture

Assigned: grimreaper » pdureau
Status: Active » Needs review
StatusFileSize
new20.27 KB

Finally, I removed the core library as its target details and summary and details.html.twig no more output those tags.

I was not able to call the accordion and accordion_item patterns because of the title and content fields. Not possible to prepare HTML to inject to those fields, it is otherwise escaped.

If someone has a tip on that, I will be happy that it is shared.

grimreaper’s picture

Assigned: pdureau » grimreaper
grimreaper’s picture

Assigned: grimreaper » pdureau

Fixing default open state.

grimreaper’s picture

Tested on my project with Drupal Commerce.

grimreaper’s picture

Assigned: pdureau » grimreaper

I need to test with forms in Layout Builder (offanvas)

grimreaper’s picture

Status: Needs review » Needs work

That's what I thought. It breaks Layout Builder offcanvas forms.

When using gin_lb it is ok because gin_lb provides template suggestions so the presenter template are not taken into account.

I will check if possible to do something similar by default.

grimreaper’s picture

Assigned: grimreaper » pdureau
Status: Needs work » Needs review
grimreaper’s picture

Assigned: pdureau » grimreaper
Status: Needs review » Needs work
grimreaper’s picture

Assigned: grimreaper » pdureau
Status: Needs work » Needs review
grimreaper’s picture

Status: Needs review » Needs work

Commerce user registration step is no more styled.

The problem is that the fieldset of this form needs to be wrapped in a div that will take the col-md-6 class and no more the fieldsets directly.

grimreaper’s picture

Assigned: pdureau » grimreaper
grimreaper’s picture

Assigned: grimreaper » pdureau
Status: Needs work » Needs review
grimreaper’s picture

Issue summary: View changes
StatusFileSize
new51.73 KB

grimreaper’s picture

Assigned: pdureau » grimreaper

  • Grimreaper committed e3409ff2 on 5.0.x
    Issue #3345265 by Grimreaper, pdureau: Document new attribute for...

  • Grimreaper committed 03e27d2e on 5.0.x
    Issue #3345265 by Grimreaper: Fix fieldset wrappers for commerce login.
    

  • Grimreaper committed a468c0b2 on 5.0.x
    Issue #3345265 by Grimreaper: details form element
    

  • Grimreaper committed 04415df9 on 5.0.x
    Issue #3345265 by Grimreaper: Automatically add row to inline label form...

  • Grimreaper committed c689abe4 on 5.0.x
    Issue #3345265 by Grimreaper: Fieldsets form element
    

  • Grimreaper committed f4d1406b on 5.0.x
    Issue #3345265 by Grimreaper: No need of the Bootstrap banner.
    
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.