Problem/Motivation
Regarding #3319153: Bootstrap 4: roadmap to first beta:
Move props from ui_patterns field to ui_settings: button.url, badge.url, media.image_url , breadcrumb.items, navbar.items
It may also be the moment to do that for Bootstrap 5 too.
Proposed resolution
Here are the current patterns where there are some "text" fields:
- accordion_item
- alert
- button
- button_group
- button_toolbar
- card_body
- dropdown
- list_group_item
- navbar
Analysis:
accordion_item:
- title: printed inside <button> => ok
alert:
- heading: printed inside <h4> => ok
button:
- label: printed inside <a> or <button> => ok
- url: used in href attribute => to rework
button_group:
- label: used inside aria-label attribute => to rework
button_toolbar:
- label: used inside aria-label attribute => to rework
card_body:
- title: printed inside <h*> => ok
- subtitle: printed inside <h*> => ok
- text: printed inside <p> => ok
dropdown:
- title: used as label field of the button pattern => ok
list_group_item:
- url: used in href attribute => to rework
navbar:
- offcanvas_label: printed inside <h5> => ok
So fields to rework:
- button.url
- button_group.label
- button_toolbar.label
- list_group_item.url
API changes
Full compatibility breaks if a website already use those patterns.
Issue fork ui_suite_bootstrap-3328657
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
grimreaperDiscussed together. A text in field is not necessarily to be converted in settings.
Comment #3
grimreaperAnalysis:
accordion_item:
- title: printed inside
<button>=> okalert:
- heading: printed inside
<h4>=> okbutton:
- label: printed inside
<a>or<button>=> ok- url: used in href attribute => to rework
button_group:
- label: used inside aria-label attribute => to rework
button_toolbar:
- label: used inside aria-label attribute => to rework
card_body:
- title: printed inside
<h*>=> ok- subtitle: printed inside
<h*>=> ok- text: printed inside
<p>=> okdropdown:
- title: used as label field of the button pattern => ok
list_group_item:
- url: used in href attribute => to rework
navbar:
- offcanvas_label: printed inside
<h5>=> okSo fields to rework:
- button.url
- button_group.label
- button_toolbar.label
- list_group_item.url
Comment #5
grimreaperFix issue summary markup
Comment #7
grimreaperComment #9
grimreaper