I am using the PageTop->alter() function, but as I am on an admin page this function does not return anything.
It would be great to have a $theme variable on this function.

Issue fork ui_skins-3468192

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rpayanm created an issue. See original summary.

rpayanm opened merge request !22

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review

Please review.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Needs work

Hi,

I am ok with the change and the feature request.

Code quality tools needs to be fixed before merging.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs work » Postponed (maintainer needs more info)

Please give more details of what is your usage.

PageTop->alter() is just an OOP wrapper around hook before Core had the ability to declare hooks in classes with PHP attribute. So its signature should match the hook one. It is not intended to be reused anywhere in the code.

What can be done is part of PageTop->alter() could be extracted in a service or put directly into the UiSkinsUtility class.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue tags: +ddd2025