Problem/Motivation

The LinkGenerator adds attributes to link. Those are used by JS to se the active class and for other stuff.

Need to reproduce it in the normalize.

Issue fork ui_patterns_settings-3437139

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

Grimreaper opened merge request !26

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
pdureau’s picture

pdureau commented

UI Patterns 2.x port will be done here: #3438432: [2.0.0-alpha2] LinksSettingType: add attributes of the link generator

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Need to test potential impact on pagination and breadcrumb.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned

No impact on breadcrumb and pagination.

The places set_active_class is used in core are:
- menu: which we want https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
- book: which we want for the book menu https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/book/...
- language block: to pass to links template https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/langu...
- links theme key: should not have impact https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them...
- menu local task: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them..., not used in UI Suite Bootstrap, but maybe a normalize should be applied in https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/src/H... and pattern should be reworked?
- menu local action: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them..., bypased in UI Suite Bootstrap https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/src/H...

christian.wiedemann’s picture

christian.wiedemann commented
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

rebasing

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned

Rebased

christian.wiedemann’s picture

christian.wiedemann commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

christian.wiedemann’s picture

christian.wiedemann commented