Closed (fixed)
Project:
UI Patterns (SDC in Drupal UI)
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Feb 2025 at 18:36 UTC
Updated:
20 Nov 2025 at 12:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
nicoloye commentedComment #5
duaelfrA bit of progress today:
* Rebased our branch on latest 2.0.x commit
* Started to factorize settings to props conversion
* Prepared future conversion of mappings to slots
* Wrote the field_formatters settings conversion
To be continued.
Comment #6
duaelfrMore progress today:
* Rebased our branch on latest 2.0.x commit
* Factorize views_styles slots conversion
* Factorize and extend dependencies conversion
* Fix 1.x missing dependencies during dependencies conversion
* Fix field_formatters variants_token conversion
* Document and harmonize views style settings conversion
* Add field_group settings conversion
* Add views row settings conversion
To be continued
Comment #7
grimreaperHello,
Updating issue status to needs work as there are code in preparation.
Would it be possible to create a MR please to see more easily the WIP? I don't wanna create it to not have commit attribution when merged (or another one could be created later).
Comment #9
grimreaperI have created the MR as WIP to be able to test it on project.
Comment #10
grimreaperComment #11
grimreaperI have code from a project for layout builder entity overrides that is generic, not related to any entity type and/or any patterns in particular.
So I will be able to share it.
Comment #12
duaelfrRerolled and resolved remaining comments
Comment #13
grimreaperDebugging config update.
Starting slot mapping conversion.
TODO:
- finish slot mapping
- cleanup todos and code quality
- provide service to refactor common code between Drush command and potential hook_update
I think regarding the migration, the process could be.
1: dev environment, destroy your env to update code with ui_patterns_legacy Drush command
2: once code is updated, rebuild your env and execute normal update
I think instead of providing a Drush command for config update, we can do that in multiple hook_update_N + hook_update_NAME.
Comment #14
grimreaperNeed real life examples to complete slots mapping. Could be completed later.
No service to refactor hook_update and Drush command.
To discuss.
Comment #15
duaelfrThe MR contains a lot of unrelated minor changes. I believe we should commit them separately to make it easier to review this massive MR and focus on the actual changes.
Comment #16
grimreaperOk, I will handle that next week.
Comment #17
grimreaperPut all changes related to coding standard on separated branch.
Maybe should go into #3541295: [2.0.9] Add missing strict_types=1 directives
Comment #18
grimreaperPatch for Composer usage. Ok on my project.
Comment #19
grimreaperDocumented Core patch.
Documented update workflow.
Refactored code duplication between hook_update_N and Drush command.
Added message at the end of hook_post_update_NAME.
I let @nicoloye prepare automated tests.
Comment #20
grimreaperComment #21
pdureau commentedComment #23
grimreaperAs discussed this morning in weekly UIP2, merged!
Thanks everyone!