we are still having issues with users being charged multiple times, yes i have already seen https://www.drupal.org/project/uc_stripe/issues/3074679 and https://www.drupal.org/project/uc_stripe/issues/3167047

we installed the latest dev release (at the time) a few months ago, that would be 7.x-3.3+10-dev but we are still having issues. including at least one case where no error was returned to Ubercart at all, but there were still two charges showing in admin/store/orders/123456/payments with the same stripe transaction id and datetime.

i know there is a newer dev release, 7.x-3.3+11-dev however i compared this with 7.x-3.3+10-dev and i only see one very small change to uc_stripe.js and i can't tell if it really addresses this multiple charges problem or not.

rather than getting into the specifics of my problem, and how to replicate it, i would just like to ask these two things:

1) is the latest change (7.x-3.3+11-dev) to do with multiple charges, or something else?

2) the documentation still says to install version 6.38.0 of the Stripe PHP Library, that is what we are currently running. this issue https://www.drupal.org/project/uc_stripe/issues/3125520 mentions making changes to make uc_stripe compatible with versions as high as 7.28 The latest version of the Stripe PHP library is currently 7.66.0 (released just a few hours ago, on Nov 24, 2020) my question is: what version of the Stripe PHP Library should we be running? the highest one available at any time? if not, what is the highest version supported by uc_stripe? if that is always changing, where do i find it, seeing that the documentation still refers to 6.38?

Comments

goatvirus created an issue.

earthangelconsulting’s picture

earthangelconsulting commented

any word from the maintainers on this?

drupal_josh’s picture

drupal_josh commented

I just had to deal with the same issue. It's supposedly fixed in the issue you linked to - https://www.drupal.org/project/uc_stripe/issues/3074679

Commit b077b015 4/29/20 has the fix.
https://git.drupalcode.org/project/uc_stripe/-/commit/b077b015002caf4ad5...

I stuck to using version 6.38.0 for the library and so far it didn't break anything but just deployed today. I'll report back if there are any issues.

earthangelconsulting’s picture

earthangelconsulting commented

@drupal_josh - thank you for the tip!

unfortunately, it looks like we are using the same code as you. we have the dev version from Oct 4, 2020, (ie: the latest dev version, 7.x-3.3+11-dev) which includes all the changes in that commit... and we are still getting the problem, though less frequently than before.

andraeray’s picture

andraeray commented

Hey guys, I'm sorry I haven't been too active in the Drupal community. I have a job and life changes and I haven't been doing much Drupal / PHP work.

@goatvirus, I'm happy that you are seeing the problem less frequently in the 7.x-3.3+11-dev version. The idempotency key is meant to prevent duplicate changes because of network issues.

The fact that it still happens means maybe users are just clicking multiple times?

I personally haven't been able to reproduce or come across any duplicate changes in my site, so It's hard for me to diagnose it.

Are either of you willing to try out this patch?
https://www.drupal.org/project/uc_stripe/issues/3074679#comment-13226049

This patch, and approach prevents double clicking of the button through JS.

earthangelconsulting’s picture

earthangelconsulting commented

hi @andraeray

the client seemed to be less concerned about this issue, i am not totally sure if the upgrading of both the Stripe PHP LIbrary and the uc_stripe module (to the latest dev release) totally fixed it, but it seemed to minimize it at least.

we never ended up trying that patch you suggested, it's been a while now and i honestly can't even remember why we didn't, sorry!