Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Coming from - http://drupal.org/project/uc_payflowpro
What are the outstanding issues to having a stable 7.x release with an API that other modules can build on?
- #2020337: Set fees that fail payment attempts to suspended status, do not expire, allow resume, new hooks.
- #2030267: Fee operation links access control faulty, wrong arguments on admin fees overview page
- #2498103: uc_recurring_get_user_fees does not unserialize data property
- #2484073: Missing argument 3 for uc_payment_method_credit_form()
- #2463951: paypal_wps recurring payment cancel help link invalid
- #2420321: Undefined property - $fee->model and $fee->rfid
- #1937840: Getting Notice: Trying to get property of non-object in node_access() when visiting products pages
- #1353762: Multiple cancel links don't redirect correctly
Comments
Comment #1
univate CreditAttribution: univate commentedI have no intention to change the API for D7.
The only thing missing from the D7 version is the CA to rules port.
Comment #2
mgiffordThanks for the update. I've reported this back to the uc_payflowpro folks. Found out they are looking for a co-maintainer, so not sure when this will happen.
Comment #3
mgiffordThanks for the update. I've reported this back to the uc_payflowpro folks. Found out they are looking for a co-maintainer, so not sure when this will happen.
Comment #4
rfayThere's a fair bit of water under the bridge since 2012 when the last uc_recurring release was rolled. How about a 7.x-2.0, or at least a 7.x-2.0-alpha3 ?
Thanks!
Comment #5
glynster CreditAttribution: glynster commented+1 this as well. We have been using this module in production on 3 very big subscription sites and works super well.
Comment #6
mgiffordThis is probably no longer an issue, but it shouldn't be marked Needs Review as there is no code.
Comment #7
glynster CreditAttribution: glynster commentedAny chance we can roll these patches into the latest dev?
https://www.drupal.org/node/2020337
https://www.drupal.org/node/2030267
Such a great module and these tweaks clean up some loose ends.
Comment #8
mgiffordOk, let's set this to active and come up with a list of issues we want to be in the next release that need to be worked on.
Comment #9
glynster CreditAttribution: glynster commentedI have listed some others that people have contributed:
Missing argument 3 for uc_payment_method_credit_form()
Hope this helps and I am sure this will improve this awesome module!
Comment #10
glynster CreditAttribution: glynster commentedWow no more feedback then :)
Comment #11
mgiffordWe aren't working on this project and have never much been more than an occasional user of it.
Adding links to issues like that isn't optimal as it doesn't include the state of the project much better to do
[#2020337] or even#2020337-8: Set fees that fail payment attempts to suspended status, do not expire, allow resume, new hooks.to highlight your issues.That said, I've edited the issue summary to add your issues to the rest of the list.
But ya, it's hard for maintainers to find time for various projects. It can be a good idea to reach out to folks, ask if there is anything that you can do to help address these issues. If the maintainer has some time & some help, some of these issues can get addressed quickly.
On the other hand, the last commit was done over a year ago, so maybe they need a co-maintainer to be added to the list to address some of these issues https://www.drupal.org/node/447668/committers
Comment #12
glynster CreditAttribution: glynster commentedI have gone ahead and contacted @univate. Would be more than happy to help where I can and possibly have a developer who might be interested in co-maintaining. I think this is such a valuable module.
Comment #13
mgiffordAlso, take a look at - https://www.drupal.org/node/251466
Comment #14
glynster CreditAttribution: glynster commented@univate and/or @Amitaibu any chance we could have the above patches committed and a stable release for Drupal 7?
Comment #15
amitaibu> or @Amitaibu any chance
I have not maintained this module for many many years, so I'm afraid I'm not your man for the task.
Comment #16
glynster CreditAttribution: glynster commented@amitaibu is there any way we could be granted a contributor permission so we could commit the updates and possibly maintain the module?
Comment #17
rfay@glynster If you're willing and able to maintain it, follow the instructions here: https://www.drupal.org/node/251466
Comment #18
amitaibuI don't have admin right. In fact, I don't even have commit rights..