Skip Checkout Review Also Skips PayPal WPS Payment

Experiencing the same issue. Took me a little while to figure out what was happening.

oops same it skips Paypal and gives me the final message of order complete.
This process is long
Fill order-checkout-Review-Submit
How do i chuck out this review (drupal 7.x-2.2)

There is a solution for this issue : http://drupal.stackexchange.com/questions/23681/ubercart-3-skip-review-s...

Get this problem too, and the solution above is not quite detail, forgive me, I am not good at code, just a user.

Can someone please tell me what I'm doing wrong? I went to the proposed fix but it doesn't work for me. I created a .module file, enabled it but I'm still getting Review Order button and have to go to that page.

The D7 version of uc_optional_checkout_review doesn't seem to work with paypal anymore. I fixed it for myself by porting the D6 version to D7 again, and have uploaded it below incase it helps someone:

https://drupal.org/files/issues/uc_optional_checkout_review.tar_.gz

#6 work for me. I think it's need include in next release

Just a note in case others had the same problem.

We had an odd server architecture where HTTPS traffic was routed via an IIS reverse proxy server, then onwards to the Linux webserver.

The ARR proxy settings in IIS had been configured to "Reverse rewrite host in response headers". This prevented the redirect to an external domain. Unchecking that, applying, and restarting IIS fixed the issue for me.

@malcolmp: thanks for the patches, I will try to review and integrate in the next release.

If more people can confirm that this works for them, I would appreciate as well. Apologies for not responding earlier.

@haysuess: no, not committed yet. I'm not really sure either what makes one work and not the other. I don't really have time/resources to do proper testing, so this might stay stuck until someone sends a proper patch.

I looked quickly at the tar.gz posted, and it doesn't do anything bad. If it works for you, may as well use that (it doesn't handle a few things fixed in the -dev version, but those are mostly exceptions, such as "pay after" support).

I just installed the tar.gz in #6 and can confirm it works for PayPal WPS

Confirmed that #6 is functional, the released version is not at all (it prevents all payments by any module, even free orders)

It seems the simple fix is that the form-altered submit was loading the order from somewhere it didn't exist.

Here's a patch

@rfay: thanks for the patch! Applied to 7.x-1.x and will release a new version shortly.

There's still a problem in there, so don't roll a new release quite yet. I'll get to it later today I expect.

I was a bit trigger happy. Thanks for the heads up.

Here's a patch that I think resolves the rest of the problem. There was an assumption that the #submit handler could go ahead and drupal_form_submit() the review form... but other modules had not yet had a chance to execute their submit handlers. So this attempts to make uc_optional_checkout_review_uc_cart_checkout_form_submit() the *last* submit handler to run, so that others have already done their duties.

I have tested this with uc_stripe, the free order, and uc_paypal, and it seems to be working OK.

@rfay: thanks again for the patch. I committed it to git. You are also now an honorary module maintainer, if you have no objection :)

I'm honored :-) I'll post patches where necessary, and if you give the go I can commit if that helps out.

Having reviewed your patches so far and checked your user profile on d.o, feel free to commit!