incorrect redirect after adding room type to cart [#673182]

i didnt see much use in having a traditional cart page for a hotel room booking after clicking the 'book this room' button on the search results page.
i therefore setup a cart redirect under the ubercart cart settings to go directly to the checkout page after adding a room through the search results. this worked fine until recently.
other products in my ubercart redirect fine to the checkout. it is only when adding a reservation that it redirects to the homepage with a drupal message stating

'product added to your cart'

i'm thinking that an error is happening in the background causing this to happen, but my site logs show nothing.

any ideas?

Comment	File	Size	Author
#5	673182.patch	998 bytes	willvincent

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

willvincent CreditAttribution: willvincent commented 3 January 2010 at 19:27

The hotel booking module has its own redirect setting so that it can be configured to redirect to the upgrade/addon product form after a booking is added to the cart.

My guess would be that is what's causing the issue. Try altering the setting for the redirect options at /admin/store/hotel_booking/hotel_settings

Comment #2

willvincent CreditAttribution: willvincent commented 4 January 2010 at 00:44

Category:	bug	» support
Status:	Active	» Needs review

Comment #3

clevername CreditAttribution: clevername commented 5 January 2010 at 00:14

Category:	support	» bug
Priority:	Normal	» Minor
Status:	Needs review	» Active

Alright found it and fixed it. Seems the real issue is that the 'URL to redirect to' field is reset to blank after clicking the 'save configuration' button at the bottom of the page. So that if you ever change anything else on the page later without re-entering your redirect link again, it screws up the redirect setting.

Comment #4

willvincent CreditAttribution: willvincent commented 5 January 2010 at 02:07

That should not be the behavior of that form element... I will take a look and fix it if necessary

Thanks

Comment #5

willvincent CreditAttribution: willvincent commented 5 January 2010 at 15:41

Status:

Active

» Fixed

File	Size
673182.patch	998 bytes

Ok, the problem was not that the value wasn't being stored, but the the variable_get command to populate that field in the form was incorrect so it wasn't reloading it on future loads of the admin form, ultimately causing it to be cleared.

The attached patch will fix this issue.

Apply it before the next time you make changes in the hotel settings admin form and you shouldn't have to reset the value again.