After filling in the checkout pane and extra field we get:
this warning about 12 times for 1 extra field.

After some testing, the presumed cause is:
When there is a recall from a previous placed order when the extra file was not yet in use or added to the pane.
Then the warnings appear, probably trying to fill in the field.

It does not happen with new orders undependable if the filed is filed in or not.

pleas advice,

And happy to see the module on drupal.org

greetings,

Comments

maurizio.ganovelli’s picture

Assigned: Unassigned » maurizio.ganovelli
Status: Active » Fixed

Hi,

This issue should be fixed in dev release. Please check it out and let me know.

ikeigenwijs’s picture

Version: » 6.x-1.x-dev
Status: Fixed » Needs work

The feedback:

I dont have the warnings anymore of the uc_extra_fields_pane.
But i got warnings when using uc_who_bought_what. witch is a super module to have working.
Can you do something with this? a little tweak maybe.

but i got:
the message:
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-mail, drupal_ge24_uc_orders.billing_phone AS Telefoon, drupal_ge24_uc_order_pro' at line 1 query: pager_query /* baverhey : pager_query */ SELECT drupal_ge24_uc_order_products.qty AS Aant, drupal_ge24_uc_orders.billing_last_name AS LName, drupal_ge24_uc_orders.billing_first_name AS FName, drupal_ge24_uc_orders.primary_email AS E-mail, drupal_ge24_uc_orders.billing_phone AS Telefoon, drupal_ge24_uc_order_products.price AS Prijs, (drupal_ge24_uc_order_products.price * drupal_ge24_uc_order_products.qty) AS Totaal, FROM_UNIXTIME(drupal_ge24_uc_orders.created, '%Y.%m.%e') AS Datum, drupal_ge24_uc_orders.payment_method AS HowPay, drupal_ge24_uc_orders.order_status AS Status, drupal_ge24_uc_orders.order_id AS ID, drupal_ge24_uc_orders.uid AS uid ,drupal_ge24_uc_order_products.data AS OrderData FROM drupal_ge24_uc_orders JOIN drupal_ge24_uc_order_products ON drupal_ge24_uc_order_products.order_id = drupal_ge24_uc_orders.order_id AND drupal_ge24_uc_order_products.nid = 50 WHERE order_status <> 'in_checkout' AND order_status <> 'canceled' ORDER BY drupal_ge24_uc_order_products.qty ASC LIMIT 0, 80 in /www/_shares/_revaki/WWW/drupal_multi/sites/all/modules/uc_who_bought_what/uc_who_bought_what.module on line 104.

After updating to the dev version of uc_extra_fields_pane

I hope you can do something with it.

thx

maurizio.ganovelli’s picture

Status: Needs work » Fixed

Hello ikeigenwijs,

please, when you find a new problem, open always a new issue for the project: in that way, i can handle patches and issues more easily.

I think that this error is indipendent from this project: all fields extracted from this query aren't handled by Extra Fields Checkout Pane.

The "real" problem is that fields name aren't correctly escaped in this query:

... drupal_ge24_uc_orders.primary_email AS E-mail, ....

should be

... drupal_ge24_uc_orders.primary_email AS `E-mail`, ....

I'll try to post a patch for this to uc_who_bought_what maintainer.

I set this issue as fixed again, thanks for your feedback.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.