First off, I don't see any "problems" with the error. I just happened to run across it in the logs.

Notice: Undefined index: triggering_element in uc_cart_view_form_submit() (line 719 of /home/mmasd/public_html/sites/all/modules/contrib/ubercart/uc_cart/uc_cart.module).

The error seems to be generated when updating a product on the /cart page. From what I can tell, everything works just fine, it updates the quantity, changes the price etc. but an error is sent to the log whenever the update button is hit.

CommentFileSizeAuthor
#1 undefined-index-error-on-cart-remove_update-1958580_1.patch617 bytesdouglasmiller
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

douglasmiller’s picture

douglasmiller CreditAttribution: douglasmiller commented
FileSize
undefined-index-error-on-cart-remove_update-1958580_1.patch617 bytes

This patch removes the notice

douglasmiller’s picture

douglasmiller CreditAttribution: douglasmiller commented
Status: Active » Needs review

status update

philsward’s picture

philsward CreditAttribution: philsward commented

Is there an actual problem going on? Or just an error? Thx for the patch btw, about to apply it.

douglasmiller’s picture

douglasmiller CreditAttribution: douglasmiller commented

There is no real problem.

The uc_cart_view_form_submit function uses the triggering_element to determine if a product has been removed from the cart. If the triggering_element is one of the remove buttons, then the form_submit will dsm the removal and set the qty to 0. The same activity is performed by uc_ajax_cart, so there should be no issue whatsoever.

I'll be on IRC in a couple of hours if you want to discuss the all in one patch attached to #2018017: I ran through the issue queue and fixed many issues