Allow defining currency code per order [#607708]

This will allow multi currency modules to set the order's currency. I'll soon post here a link to a new multi currency field that uses CCK for it's currency and price logic.

Patch will probably need to grow and cover all payment methods, with a function that returns the currency code

uc_order_get_currency_code($order) {
  return !empty($order->currency_code) ? !empty($order->currency_code) : variable_get('uc_paypal_wps_currency', 'USD');
}

Comment	File	Size	Author
#12	607708-currency-per-order.patch	1.42 KB	longwave
#12
#7	allow-define-currency-code-per-order-temp-fix.patch	1.24 KB	sokrplare
#7
#4	uc_paypal.module.patch	3.69 KB	nicolasb_cdip
#4
#3	allow-define-currency-code-per-order-3.patch	1.24 KB	amitaibu
#3
#2	allow-define-currency-code-per-order-2.patch	940 bytes	amitaibu
#2
	allow-define-currency-code-per-order.patch	948 bytes	amitaibu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 18 October 2009 at 11:17

And here's the module as a use case:
http://drupal.org/project/uc_cck_currency

Comment #2

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 1 November 2009 at 08:57

File	Size
allow-define-currency-code-per-order-2.patch	940 bytes

Oops, fix typo that sent the wrong currency code.

File	Size
allow-define-currency-code-per-order-3.patch	1.24 KB

File	Size
uc_paypal.module.patch	3.69 KB

I'm using Paypal with uc_cck_currency module and I have managed to use your patches and provide one which allowed me to perform a successfull Paypal payment with two different currencies.
So in the file you patched there are other places where I made kind of the same modif.
Anyway here is a patch for the uc_paypal.module file.

I would be pleased to have any feedback.

Comment #5

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 4 March 2010 at 18:37

@nicolasb_cdip,
your patch isn't good for Ubercart core, as it deals with contrib module. The patch in #3 is still valid -- As part of uc_cck_currency overhaul I forgot to re-populte $order->currency_code, except a fix for that in the coming few days.

Comment #6

nicolasb_cdip CreditAttribution: nicolasb_cdip commented 5 March 2010 at 09:10

I missunderstood what you meant. So the function "uc_order_get_currency_code($order)" would return the currency code which is $order->data["uc_cck_currency"]["code"] if the user is using uc_cck_currency module isn't it ?
Where would you define such a function ?
I'd like to know why aren't there other lines where you should change "'CURRENCYCODE' => " as I did with my patch ? Is your patch actually working and allows you to perform a successfull Paypal payment with two different currencies ?

Comment #7

sokrplare CreditAttribution: sokrplare commented 19 March 2010 at 07:13

File	Size
allow-define-currency-code-per-order-temp-fix.patch	1.24 KB

Since I haven't seen the fix for repopulating $order->currency_code I had to switch to reference $order->data['uc_cck_currency']['code'] to get this working on a client's site. Would be happy to know when the fix is in place so I can roll this back!

In the meantime, posting the patch to save someone time until you get a few free moments, Amitaibu. Thanks for a great module!

Comment #8

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 25 March 2010 at 10:36

I have committed a fix to uc_cck_currenycy -- http://drupal.org/cvs?commit=346032

So the patch in #3 is still the correct one.

Comment #9

abubin CreditAttribution: abubin commented 13 July 2010 at 08:45

i already applied path #3 but is having problem when checkout with paypal.

The currency still follows the one I set inside Currency Code in "PayPal Website Payments Standard".

I had my default currency as SGD and added field_mc_usd. Display of the prices work correctly in checkout cart but when in paypal site, it shows same currency I set in PayPal Website Payments Standard and doesn't change. Amount will be changed but currency does not.

Please help...