If a user has FCKEditor installed, the Order Comments box will use it and will therefore generate and send HTML to Paypal along with the order. I think you need to speak with the developers of FCKEditor and get them to add this text area to their default exclude list. (The ID for excluding or including this element is: edit-panes-comments-comments - the path is: cart/checkout)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama’s picture

Category: bug » feature
Status: Active » Postponed

There are really a bunch of different textareas that should have WYSIWYG editors disabled. I don't think we can really accommodate this in core until Drupal core accommodates it and gives us a standard way to do it... otherwise we'll be chasing down a half-dozen modules to keep up with how they handle it. I hear D7 may get some WYSIWYG editor love in it, so we might need to wait till then.

AlexisWilke’s picture

Assigned: Unassigned » AlexisWilke
Status: Postponed » Active
FileSize
423 bytes

Hi rszrama,

From what I have seen, there is just ONE way to do it properly. It works in 99% of the cases I ran into and that's by adding a '#wysiwyg' attribute. I'm attaching a patch to show you how to do it with the comments. The ones that the user have access to is particularly important!

Thank you for your consideration.
Alexis

AlexisWilke’s picture

There is another one... 8-)

Thank you.
Alexis

P.S. Wrong patch, it says TRUE instead of FALSE... sorry

AlexisWilke’s picture

Fixed patch #2

TR’s picture

I don't have any problem adding the form attribute. If it's good enough for David Reid it's good enough for me: #716096: Support the #wysiwyg form element property for manual exclusion

Can you roll one patch to fix *all* textareas/textfields in Ubercart where you think this is a problem? I know there's at least one other issue where the store e-mail address was wrapped in <p></p> and caused a problem - there are probably a few others.

AlexisWilke’s picture

Here is a patch. It is difficult for me to tell whether a box is or not a text field or HTML capable, but I did my best to determine whenever I could not tell for sure. I suggest that you review the changes and whether other files should be changed.

The following is a list of all the files that include at least one textarea field:

 ubercart/ca/ca.admin.inc
 ubercart/ca/ca.ca.inc
 ubercart/payment/uc_credit/uc_credit.module
 ubercart/payment/uc_cybersource/uc_cybersource.module
 ubercart/payment/uc_payment_pack/uc_payment_pack.module
 ubercart/payment/uc_paypal/uc_paypal.pages.inc
 ubercart/payment/uc_google_checkout/uc_google_checkout.admin.inc
 ubercart/shipping/uc_quote/uc_quote.admin.inc
 ubercart/uc_cart/uc_cart.admin.inc
 ubercart/uc_cart/uc_cart_checkout_pane.inc
 ubercart/uc_cart_links/uc_cart_links.admin.inc
 ubercart/uc_file/uc_file.ca.inc
 ubercart/uc_order/uc_order.ca.inc
 ubercart/uc_order/uc_order.order_pane.inc
 ubercart/uc_product/uc_product.admin.inc
 ubercart/uc_product_kit/uc_product_kit.module
 ubercart/uc_roles/uc_roles.ca.inc
 ubercart/uc_store/uc_store.admin.inc

Thank you.
Alexis Wilke

TR’s picture

Status: Active » Needs review
AlexisWilke’s picture

Title: Order comments textarea for Paypal checkout should be excluded from FCKEditor » Exclude textarea's widgets from WYSIWYG editors

Fixed the title since the last patch is for any WYSIWYG editor that implements the '#wywiwyg' => FALSE feature.

longwave’s picture

Updated patch for 6.x-2.x-dev

TR’s picture

#9: 321633-exclude-wysiwyg.patch queued for re-testing.

TR’s picture

Version: 6.x-2.x-dev » 7.x-3.x-dev
Assigned: AlexisWilke » Unassigned
Status: Needs review » Patch (to be ported)

Committed! Let's forward port this to 7.x-3.x.

If there are other places we missed, we can always add them later.

AlexisWilke’s picture

Thank you TR. 8-)
Alexis

longwave’s picture

Not sure this is needed in D7 as it only applies to the 'text_format' form element, which we don't seem to use. See http://drupal.org/node/1087468

longwave’s picture

Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

Confirmed that with WYSIWYG module enabled and configured on D7, for example the order comments box at checkout does not have any WYSIWYG functionality even without this patch, so there is nothing to do here in D7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.