Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If a user has FCKEditor installed, the Order Comments box will use it and will therefore generate and send HTML to Paypal along with the order. I think you need to speak with the developers of FCKEditor and get them to add this text area to their default exclude list. (The ID for excluding or including this element is: edit-panes-comments-comments - the path is: cart/checkout)
Comment | File | Size | Author |
---|---|---|---|
#9 | 321633-exclude-wysiwyg.patch | 8.84 KB | longwave |
#6 | ubercart-wysiwyg-6.x.patch | 9.5 KB | AlexisWilke |
#4 | ubercart-credit_card_type-6.x.patch | 638 bytes | AlexisWilke |
#3 | ubercart-credit_card_type-6.x.patch | 637 bytes | AlexisWilke |
#2 | ubercart-cart_comments-6.x.patch | 423 bytes | AlexisWilke |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedThere are really a bunch of different textareas that should have WYSIWYG editors disabled. I don't think we can really accommodate this in core until Drupal core accommodates it and gives us a standard way to do it... otherwise we'll be chasing down a half-dozen modules to keep up with how they handle it. I hear D7 may get some WYSIWYG editor love in it, so we might need to wait till then.
Comment #2
AlexisWilke CreditAttribution: AlexisWilke commentedHi rszrama,
From what I have seen, there is just ONE way to do it properly. It works in 99% of the cases I ran into and that's by adding a '#wysiwyg' attribute. I'm attaching a patch to show you how to do it with the comments. The ones that the user have access to is particularly important!
Thank you for your consideration.
Alexis
Comment #3
AlexisWilke CreditAttribution: AlexisWilke commentedThere is another one... 8-)
Thank you.
Alexis
P.S. Wrong patch, it says TRUE instead of FALSE... sorry
Comment #4
AlexisWilke CreditAttribution: AlexisWilke commentedFixed patch #2
Comment #5
TR CreditAttribution: TR commentedI don't have any problem adding the form attribute. If it's good enough for David Reid it's good enough for me: #716096: Support the #wysiwyg form element property for manual exclusion
Can you roll one patch to fix *all* textareas/textfields in Ubercart where you think this is a problem? I know there's at least one other issue where the store e-mail address was wrapped in
<p></p>
and caused a problem - there are probably a few others.Comment #6
AlexisWilke CreditAttribution: AlexisWilke commentedHere is a patch. It is difficult for me to tell whether a box is or not a text field or HTML capable, but I did my best to determine whenever I could not tell for sure. I suggest that you review the changes and whether other files should be changed.
The following is a list of all the files that include at least one textarea field:
Thank you.
Alexis Wilke
Comment #7
TR CreditAttribution: TR commentedComment #8
AlexisWilke CreditAttribution: AlexisWilke commentedFixed the title since the last patch is for any WYSIWYG editor that implements the '#wywiwyg' => FALSE feature.
Comment #9
longwaveUpdated patch for 6.x-2.x-dev
Comment #10
TR CreditAttribution: TR commented#9: 321633-exclude-wysiwyg.patch queued for re-testing.
Comment #11
TR CreditAttribution: TR commentedCommitted! Let's forward port this to 7.x-3.x.
If there are other places we missed, we can always add them later.
Comment #12
AlexisWilke CreditAttribution: AlexisWilke commentedThank you TR. 8-)
Alexis
Comment #13
longwaveNot sure this is needed in D7 as it only applies to the 'text_format' form element, which we don't seem to use. See http://drupal.org/node/1087468
Comment #14
longwaveConfirmed that with WYSIWYG module enabled and configured on D7, for example the order comments box at checkout does not have any WYSIWYG functionality even without this patch, so there is nothing to do here in D7.