DDEV is the official local development tool of Drupal. And like Drupal, DDEV depends on the support of the open source community.Problem/Motivation
When showing the product Display Price fields in Views, amount does not include Taxes.
Proposed resolution
Load all taxes and add the amount to field's value IF Tax plugin is configured to be included in Product price.
Patch attached :
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 0001-2999953-Rework-Views-DisplayPrice-include-taxes.patch | 1.22 KB | matthieuscarset |
Comments
Comment #2
matthieuscarset CreditAttribution: matthieuscarset as a volunteer and commentedAttaching patch.
Comment #3
tr CreditAttribution: tr commentedPlease look at this related issue and let's solve this for D8 and D7 at the same time.
If you set your issue to "Needs review" when you post a patch, the testbot will automatically test it. For Drupal 8 we're trying to follow the core Drupal practice of putting in tests every time we add a feature or fix a bug - it would be nice to have a test case for this Views field to ensure that once this gets fixed it stays fixed ...
Comment #5
tr CreditAttribution: tr commentedPatch is corrupt - it looks like the last line is missing.
Comment #6
matthieuscarset CreditAttribution: matthieuscarset as a volunteer and commentedClosing this issue as apparently is won't get fixed
Comment #7
tr CreditAttribution: tr commentedHey if you want it fixed then provide a patch and respond to the feedback from #3. This issue has been waiting for YOU and no one else ...
Comment #8
matthieuscarset CreditAttribution: matthieuscarset as a volunteer and commentedYes.
I won't fix it so I close it as "won't fix".
I think it makes sense.
Comment #9
tr CreditAttribution: tr commentedIt's still a bug, so it should remain open so anyone can participate or provide a solution.