As described in the change notice: Time Service Added and REQUEST_TIME deprecated

CommentFileSizeAuthor
#9 2933455-9.patch13.34 KBTR
#7 ppc2.patch7.96 KBTR
#5 ppc.patch7.93 KBTR
#4 rt.patch4.01 KBTR
#2 2933455-2.patch23.2 KBTR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR created an issue. See original summary.

TR’s picture

TR CreditAttribution: TR commented
Status: Active » Needs review
FileSize
2933455-2.patch23.2 KB

Here's a patch for all of the time() and about half of the REQUEST_TIME. All of the remaining REQUEST_TIME need to have the service injected, which will take a little more work. I only did that for a few of the cases in this patch, the rest are procedural calls which can't use injection.

  • TR committed e4d4c37 on 8.x-4.x 
    Issue #2933455 by TR: Replace time() and REQUEST_TIME with datetime.time...
TR’s picture

TR CreditAttribution: TR commented
FileSize
rt.patch4.01 KB

A few more.

TR’s picture

TR CreditAttribution: TR commented
FileSize
ppc.patch7.93 KB

Related patch for PayPalController. Injecting REQUEST_TIME, but there are also a lot of other services that need injecting, so doing them all at once.

Status: Needs review » Needs work

The last submitted patch, 5: ppc.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

TR’s picture

TR CreditAttribution: TR commented
Status: Needs work » Needs review
FileSize
ppc2.patch7.96 KB

Fix typo.

  • TR committed d2eed7c on 8.x-4.x 
    Inject services into PayPalController.  #2933455-7
  • TR committed d419df6 on 8.x-4.x
    Replace time() and REQUEST_TIME with datetime.time service.  #2933455-4
TR’s picture

TR CreditAttribution: TR commented
FileSize
2933455-9.patch13.34 KB

Inject datetime.time into some forms ...

  • TR committed 1d36c3a on 8.x-4.x 
    Issue #2933455 by TR: Inject datetime.time into some forms