The Ubercart 7.x-3.x tests currently fail to run because of a bug in the google_analytics module.

Ubercart includes uc_googleanalytics, which depends on the google_analytics module. Because the google_analytics module has a syntax error in its current stable release 7.x-2.4, the testbot fails with a syntax error when it tries to load google_analytics. This aborts the remainder of the Ubercart testing. The bug was introduced in #2693595: Drupal sending Personally identifiable info to Google Analytics, and it doesn't appear there will be a new stable release of google_analytics to fix this bug.

Until there is a new stable release for google_analytics, we can avoid the problem by changing the uc_googleanalytics dependency to be dependencies[] = googleanalytics (!=7.x-2.4), meaning we will allow the testbot to use any version of google_analytics EXCEPT for the buggy 7.x-2.4.

Patch attached to test this ...

CommentFileSizeAuthor
#7 ubercart-google_analytics-php5.4+-2913705-7.patch517 bytesjantoine
google_analytics_bug.patch515 bytesTR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR created an issue. See original summary.

TR’s picture

TR CreditAttribution: TR commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, google_analytics_bug.patch, failed testing. View results

  • TR committed 4f0a65c on 7.x-3.x 
    Issue #2913705 by TR: Test failure with Drupal 7.x
TR’s picture

TR CreditAttribution: TR commented
Status: Needs work » Fixed

I had to commit the patch directly - the testbot parses the modules (and fails on the syntax error in google_analytics) BEFORE it applies patches like the one above, so there's no way to test the fix with the testbot.

Fortunately, the patch worked (see https://www.drupal.org/pift-ci-job/777606) and the Ubercart 7.x-3.x tests now run properly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jantoine’s picture

jantoine CreditAttribution: jantoine as a volunteer commented
FileSize
ubercart-google_analytics-php5.4+-2913705-7.patch517 bytes

I've attached a patch to revert the change from this issue for those of us using PHP 5.4+ and have already upgraded Google Analytics to v2.4.

TR’s picture

TR CreditAttribution: TR commented
Related issues: +#2944051: Google Analytics version

Yes, we still don't have a new Google Analytics release with the syntax error fixed, four months later.

To repeat what I said in #2944051-3: Google Analytics version , if you are using GA 5.4 and have problems upgrading to Ubercart 7.x-3.11 because of this your choices are:

  1. Upgrade to Google Analytics 7.x-2.x-dev. Nothing further is required.
  2. Downgrade to Google Analytics 7.x-2.3. Nothing further is required.
  3. Apply the Google Analytics patch https://cgit.drupalcode.org/google_analytics/commit/?id=bde441d , which fixes the syntax error. Then make the modification below.
  4. Use PHP 5.4 or higher so this Google Analytics bug won't affect you. Then make the modification below.

If you choose #3 or #4, you will have to modify uc_googleanalytics.info and change:
dependencies[] = googleanalytics (!=7.x-2.4)
to read:
dependencies[] = googleanalytics