Tokens in stock notifications are double escaped [#2891350]

For instance, if a node has a & in its title, [node:title] will display & instead of & in the mail.

Comment	File	Size	Author
#4	stock_notifications_double_escaped-2891350-4-full.patch	3.58 KB	anrikun
#4	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 125 pass
#4	stock_notifications_double_escaped-2891350-4-tests_only.patch	2.75 KB	anrikun
#4	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 124 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

30 June 2017 at 22:11

anrikun created an issue. See original summary.

Comment #2

anrikun CreditAttribution: anrikun commented 30 June 2017 at 23:12

Status:

Active

» Closed (works as designed)

But even with a & in product title, stock tests pass though. Problem must be elsewhere.

Comment #3

anrikun CreditAttribution: anrikun commented 30 June 2017 at 23:32

Status:

Closed (works as designed)

» Active

Got it. Stock notification tests pass because they are run through TestingMailSystem instead of UbercartMailSystem.
So basically tests are wrong too.

Comment #4

anrikun CreditAttribution: anrikun commented 1 July 2017 at 16:15

Status:

Active

» Needs review

File	Size
stock_notifications_double_escaped-2891350-4-tests_only.patch	2.75 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 124 pass, 1 fail
stock_notifications_double_escaped-2891350-4-full.patch	3.58 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 125 pass

Let's try these:
1. Updated and fixed tests: should fail
2. Full patch: should pass

Comment #5

TR CreditAttribution: TR commented 2 July 2017 at 17:24

Status:

Needs review

» Active

The stock e-mails, and everything else sent with UbercartMailSystem, are assumed to be HTML content. So & *should* be replaced by & (single encoding). Are you saying the text actually contains &amp; (double encoding)?

Comment #6

anrikun CreditAttribution: anrikun commented 2 July 2017 at 16:36

Status:

Active

» Needs review

Yes, I mean double encoding.
As HTML is expected, tokens should not be sanitized.

Comment #7

anrikun CreditAttribution: anrikun commented 3 July 2017 at 09:15

@TR
Here is my stock notifications config (sorry it's in French):
Subject: Seuil de stock atteint pour [node:title] ([uc_stock:model])
Body: Le niveau du stock de l’article [node:title] ([uc_stock:model]) a atteint [uc_stock:level].

And the mail I've received for a product called "Jaked R&R Fenice":