HTTPRL seems to be the most straightforward library for making multi-threaded parallel requests in Drupal 7. This patch adds HTTPRL as a test dependency so we can write tests for race conditions.

CommentFileSizeAuthor
ubercart-test-dependencies-httprl.patch345 bytesmfb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfb created an issue. See original summary.

TR’s picture

TR CreditAttribution: TR commented

I have no objection to this so long as it accompanies a test case that requires it, e.g. for #2884536: Add a lock to improve prevention of double order completion (race condition). I don't want to add a dependency on speculation that we might needed it.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented

yes this is a prerequisite for its parent issue. AFAIK testbot cannot run tests that use a new test dependency until that test dependency has been committed.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented

Can we get this in so it's possible to run tests in the parent issue?

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented

Would love to get some reviews on this, as the race condition is problematic.