If we turn off all the fields on the checkout page
/admin/store/settings/countries/fields
Then after editing any order
For example page:
/admin/store/orders/ORDER_ID/edit
There are errors:
Notice: Undefined variable: changes в функции uc_order_pane_ship_to() (строка 77 в файле /var/www/jeto/data/www/jeto.ru/sites/all/modules/ubercart/uc_order/uc_order.order_pane.inc).
Notice: Undefined variable: changes в функции uc_order_pane_bill_to() (строка 121 в файле /var/www/jeto/data/www/jeto.ru/sites/all/modules/ubercart/uc_order/uc_order.order_pane.inc).

Bug in the code:

  case 'edit-process':
    foreach ($form_state['values'] as $key => $value) {
      if (substr($key, 0, 9) == 'delivery_') {
        if (uc_address_field_enabled(substr($key, 9))) {
          $changes[$key] = $value;
        }
      }
    }
    return $changes;

Not one field is not included, hence the data is not assembled into a variable, hence there is no variable.
Patch I enclose.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yuraosn created an issue. See original summary.

yuraosn’s picture

Status: Active » Patch (to be ported)
TR’s picture

Version: 7.x-3.10 » 7.x-3.x-dev
Status: Patch (to be ported) » Needs review

Status: Needs review » Needs work

The last submitted patch, uc_order--fixed-notice-variable-changes.patch, failed testing.

yuraosn’s picture

Version: 7.x-3.x-dev » 7.x-3.10
TR’s picture

Version: 7.x-3.10 » 7.x-3.x-dev

In Drupal, fixed point releases like 7.x-3.10 can't be changed - all patches must apply to the head of the development branch, in this case 7.x-3.x-dev.

Your patch failed the test because it is in the wrong format. It looks like you used -p4 instead of -p1. Please fix the format and upload the patch again. See https://www.drupal.org/patch for more details.

TR’s picture

Status: Needs work » Needs review
FileSize
1.98 KB

Here's a real patch for the testbot to try...

  • TR committed 657effb on 7.x-3.x
    Issue #2862008 by yuraosn, TR: Notice: Undefined variable: changes
    
TR’s picture

Status: Needs review » Fixed

Committed #7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.