Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nikhilesh Gupta created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, ubercart.patch, failed testing.

Nikhilesh Gupta’s picture

Title: Removed deprecated method » Deprecated method
Assigned: Nikhilesh Gupta » Unassigned
Status: Needs work » Needs review
FileSize
6.3 KB

Status: Needs review » Needs work

The last submitted patch, 3: ubercart.patch, failed testing.

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
7.74 KB
4.29 KB

Done some changes.

Adding interdiff for reference.

Status: Needs review » Needs work

The last submitted patch, 5: 2755909-5.patch, failed testing.

rajeshwari10’s picture

Status: Needs review » Needs work

The last submitted patch, 7: 2755909-7.patch, failed testing.

rajeshwari10’s picture

rajeshwari10’s picture

TR’s picture

You can't change the constructor signature for subclasses of EntityViewBuider or ContentEntityForm.

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
4.54 KB
4 KB

Done changes as said in #12.

Attaching interdiff.

  • TR committed bce4000 on 8.x-4.x authored by rajeshwari10
    Issue #2755909 by rajeshwari10, Nikhilesh Gupta: Deprecated method
    
TR’s picture

Status: Needs review » Fixed

Committed. Thanks for working on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.